Hi,
last week I send a mail asking for some small re-architectures of mini-os for
porting to ia64. Unfortunately I didn''t get an answer so I try it again
with a
first draft. I tried the changes as small as possible. Currently I did only
adding some new directories and moving some files.
I created:
mini-os/include/x86
It''s for common header files for x86_32 and x86_64, currently os.h
and
spinlock.h .
mini-os/include/x86_32
It''s for special x86_32 header files, currently hypercall-x86_32.h.
mini-os/include/x86_64
It''s for special x86_64 header files, currently hypercall-x86_64.h.
mini-os/x86
For common code files for x86_32 and x86_64, currently traps.c
I changed mini-os/Makefile to support the new structure.
Please can anybody look at this and give some feedback.
Thanks.
Dietmar.
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel
Am Dienstag, 1. August 2006 08:28 schrieb Dietmar Hahn:> Hi, > > last week I send a mail asking for some small re-architectures of mini-os for > porting to ia64. Unfortunately I didn''t get an answer so I try it again with a > first draft. I tried the changes as small as possible. Currently I did only > adding some new directories and moving some files. > I created: > mini-os/include/x86 > It''s for common header files for x86_32 and x86_64, currently os.h and > spinlock.h . > mini-os/include/x86_32 > It''s for special x86_32 header files, currently hypercall-x86_32.h. > mini-os/include/x86_64 > It''s for special x86_64 header files, currently hypercall-x86_64.h. > mini-os/x86 > For common code files for x86_32 and x86_64, currently traps.c > > I changed mini-os/Makefile to support the new structure. > Please can anybody look at this and give some feedback. > Thanks. > > Dietmar. >Sorry for not sending a real patch (I''am still learning!). This is done now. Thanks. Dietmar. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Dear Dietmar Yes, I''m Mini-OS maintainer. It''s great that somebody wants to port it to IA64. With respect to your patch. I would prefer to see the following directory structure: mini-os/include/x86 mini-os/include/x86/x86_32 mini-os/include/x86/x86_64 If we find that there is only one file in x86_32/x86_64 it would be better to scrap the two directories and put the files in x86. Continuing, architecture dependent .c files should end up in: mini-os/arch/x86 mini-os/arch/x86/x86_32 mini-os/arch/x86/x86_64 The above is consistant with the directory structure in xen itself. I have also noticed that you left some debug statements in your version of Makefile. Obviously we will not commit these to the public repository. So if you remove them before dumping the diff it would make my life little easier. Finally, when you moved the files around, have you used: hg mv, or just mv. The first one is better :). Cheers Gregor On 1 Aug 2006, at 07:28, Dietmar Hahn wrote:> Hi, > > last week I send a mail asking for some small re-architectures of > mini-os for > porting to ia64. Unfortunately I didn''t get an answer so I try it > again with a > first draft. I tried the changes as small as possible. Currently I > did only > adding some new directories and moving some files. > I created: > mini-os/include/x86 > It''s for common header files for x86_32 and x86_64, currently > os.h and > spinlock.h . > mini-os/include/x86_32 > It''s for special x86_32 header files, currently hypercall- > x86_32.h. > mini-os/include/x86_64 > It''s for special x86_64 header files, currently hypercall- > x86_64.h. > mini-os/x86 > For common code files for x86_32 and x86_64, currently traps.c > > I changed mini-os/Makefile to support the new structure. > Please can anybody look at this and give some feedback. > Thanks. > > Dietmar. > <mini-os.diff> > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Dietmar Hahn
2006-Aug-03 12:24 UTC
Re: [Xen-devel] [PATCH][RESEND] Porting Mini-OS to ia64
Hi Grzegorz , Am Donnerstag, 3. August 2006 12:30 schrieb Grzegorz Milos:> Dear Dietmar > > Yes, I''m Mini-OS maintainer. It''s great that somebody wants to port > it to IA64. >Nice to hear.> With respect to your patch. I would prefer to see the following > directory structure: > mini-os/include/x86 > mini-os/include/x86/x86_32 > mini-os/include/x86/x86_64 > If we find that there is only one file in x86_32/x86_64 it would be > better to scrap the two directories and put the files in x86. > > Continuing, architecture dependent .c files should end up in: > mini-os/arch/x86 > mini-os/arch/x86/x86_32 > mini-os/arch/x86/x86_64 > > The above is consistant with the directory structure in xen itself.Yes you are right!> > I have also noticed that you left some debug statements in your > version of Makefile. Obviously we will not commit these to the public > repository. So if you remove them before dumping the diff it would > make my life little easier. >Sorry, I saw this short time after sending the patch - now it''s fixed;-).> Finally, when you moved the files around, have you used: hg mv, or > just mv. The first one is better :). >Yes I did ''hg rename''.> Cheers > Gregor >I moved only few files and changed the Makefile. In the next step I will look into the files for special defines for x86_32 and x86_64. I hope this patch is ok now. Thanks. Dietmar. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Grzegorz Milos
2006-Aug-07 12:50 UTC
Re: [Xen-devel] [PATCH][RESEND] Porting Mini-OS to ia64
>> With respect to your patch. I would prefer to see the following >> directory structure: >> mini-os/include/x86 >> mini-os/include/x86/x86_32 >> mini-os/include/x86/x86_64 >> If we find that there is only one file in x86_32/x86_64 it would be >> better to scrap the two directories and put the files in x86. >> >> Continuing, architecture dependent .c files should end up in: >> mini-os/arch/x86 >> mini-os/arch/x86/x86_32 >> mini-os/arch/x86/x86_64 >> > I moved only few files and changed the Makefile. In the next step I will look > into the files for special defines for x86_32 and x86_64. > I hope this patch is ok now.The patch still introduces mini-os/include/x86_32 and mini-os/include/x86_64. I would prefer both x86_32 and x86_64 to be subdirectories of mini-os/include/x86. Also, I would replace "=" with "+=" when you assign to EXTRA_INC/SRC in mini-os/Makefile. Cheers Gregor _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Dietmar Hahn
2006-Aug-08 11:36 UTC
Re: [Xen-devel] [PATCH][RESEND] Porting Mini-OS to ia64
Am Montag, 7. August 2006 14:50 schrieb Grzegorz Milos:> >> With respect to your patch. I would prefer to see the following > >> directory structure: > >> mini-os/include/x86 > >> mini-os/include/x86/x86_32 > >> mini-os/include/x86/x86_64 > >> If we find that there is only one file in x86_32/x86_64 it would be > >> better to scrap the two directories and put the files in x86. > >> > >> Continuing, architecture dependent .c files should end up in: > >> mini-os/arch/x86 > >> mini-os/arch/x86/x86_32 > >> mini-os/arch/x86/x86_64 > > > > I moved only few files and changed the Makefile. In the next step I will > > look into the files for special defines for x86_32 and x86_64. > > I hope this patch is ok now. > > The patch still introduces > mini-os/include/x86_32 and mini-os/include/x86_64.Sorry I overlooked the right directory hierarchy.> > I would prefer both x86_32 and x86_64 to be subdirectories of > mini-os/include/x86.I hope, now it''s correct!> > Also, I would replace "=" with "+=" when you assign to EXTRA_INC/SRC in > mini-os/Makefile.OK I did this. I also added some lines for creating architecture dependent links. Maybe there are some discussion points about the rules I added.> > Cheers > Gregor >Thanks for understanding. Dietmar. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Grzegorz Milos
2006-Aug-09 14:39 UTC
Re: [Xen-devel] [PATCH][RESEND] Porting Mini-OS to ia64
This patch looks fine. Keir could you apply please? Cheers Gregor On 8 Aug 2006, at 12:36, Dietmar Hahn wrote:> Am Montag, 7. August 2006 14:50 schrieb Grzegorz Milos: >>>> With respect to your patch. I would prefer to see the following >>>> directory structure: >>>> mini-os/include/x86 >>>> mini-os/include/x86/x86_32 >>>> mini-os/include/x86/x86_64 >>>> If we find that there is only one file in x86_32/x86_64 it would be >>>> better to scrap the two directories and put the files in x86. >>>> >>>> Continuing, architecture dependent .c files should end up in: >>>> mini-os/arch/x86 >>>> mini-os/arch/x86/x86_32 >>>> mini-os/arch/x86/x86_64 >>> >>> I moved only few files and changed the Makefile. In the next step >>> I will >>> look into the files for special defines for x86_32 and x86_64. >>> I hope this patch is ok now. >> >> The patch still introduces >> mini-os/include/x86_32 and mini-os/include/x86_64. > Sorry I overlooked the right directory hierarchy. > >> >> I would prefer both x86_32 and x86_64 to be subdirectories of >> mini-os/include/x86. > I hope, now it''s correct! > >> >> Also, I would replace "=" with "+=" when you assign to EXTRA_INC/ >> SRC in >> mini-os/Makefile. > OK I did this. > I also added some lines for creating architecture dependent links. > Maybe there are some discussion points about the rules I added. > >> >> Cheers >> Gregor >> > Thanks for understanding. > > Dietmar. > <mini-os.patch>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel