Xen devel - Jul 2006 - [Patch] Fix cirrus and rt8139 co-exist issue

Keir,
This patch fixes cirrus and rt8139 co-exist issue in new qemu-dm. The
root cause is that if two MMIO spaces are continuous, qemu may misuse
last MMIO space''s read/write to handle current request. 

Thanks,
Xiaowei

Signed-off-by: Yang Xiaowei <xiaowei.yang@intel.com>
diff -r ecb8ff1fcf1f tools/ioemu/target-i386-dm/exec-dm.c
--- a/tools/ioemu/target-i386-dm/exec-dm.c      Fri Jul 14 17:53:27 2006
+++ b/tools/ioemu/target-i386-dm/exec-dm.c      Mon Jul 17 17:55:34 2006
@@ -382,7 +385,7 @@
                 start = mmio[i].start;
                 end = mmio[i].start + mmio[i].size;

-                if ((addr >= start) && (addr <= end)){
+                if ((addr >= start) && (addr < end)){
                         return (mmio[i].io_index >> IO_MEM_SHIFT) &
(IO_MEM_NB_ENTRIES - 1);
                 }
         }

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>This patch fixes cirrus and rt8139 co-exist issue in new qemu-dm. The
>root cause is that if two MMIO spaces are continuous, qemu may misuse
>last MMIO space''s read/write to handle current request.
>
Keir,
This is a critical patch to make network and display workable in new
qemu -dm. Please apply it.

Thanks,
Xiaowei


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 26 Jul 2006, at 04:23, Yang, Xiaowei wrote:
>> This patch fixes cirrus and rt8139 co-exist issue in new qemu-dm. The
>> root cause is that if two MMIO spaces are continuous, qemu may misuse
>> last MMIO space''s read/write to handle current request.
>>
>
> Keir,
> This is a critical patch to make network and display workable in new
> qemu -dm. Please apply it.
>
> Thanks,
> Xiaowei
Christian Limpach is maintaining the qemu codebase now. There are a 
couple of outstanding patches that I think he''ll be checking in today.

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 7/26/06, Yang, Xiaowei <xiaowei.yang@intel.com>
wrote:
> >This patch fixes cirrus and rt8139 co-exist issue in new qemu-dm. The
> >root cause is that if two MMIO spaces are continuous, qemu may misuse
> >last MMIO space''s read/write to handle current request.
> >
>
> Keir,
> This is a critical patch to make network and display workable in new
> qemu -dm. Please apply it.
Applied, thanks!

     christian

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel