Ian Pratt
2006-Jul-07 19:41 UTC
RE: [Xen-devel] Why gnttab_grant_foreign_access() can only grantaccess for one page?
> I just read the source code. gnttab_grant_foreign_access() seems tojust> set some data in an in-memory structure "shared". No hypercall isneeded> here. Right? > If so, whether calling this function in a batch mode does not make big > difference to me. I thought a gnttab_grant_foreign_access() will causea> hypercall and context switch, then > whether we can do batch granting will be important to performance.Yes, only one side of the interface requires hypercalls.> Ian, you said "grant tables are not typically used to map machine > contiguous regions". Does Xen provide any mechanism to map contiguous > regions?Not as yet as it hasn''t been needed. Are you sure the pages you want to map are machine (as opposed to just guest physical) contiguous.> Another question: Grant table currently seems to only allow 1024entries,> which means a domain may grant remote access on at most 1024 pages. > However, this may not be enough in some cases. For example, in mycase, I> need to allow a backend VM to share many pages with frontend. I can > certainly change the xen code to make the grant table larger. But doesXen> has a better way to handle this situation?There should be a hypercall to grow a domain''s grant table. It''s been on the todo list for a while. Want to knock something up? Thanks, Ian> thanks, > lily > > > On 7/7/06, Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk> wrote: > > > Lily Huang wrote: > > > > > THis seems to be less efficient. Why cannot we allow this > function > > > to grant access for mulitiple pages just remap function? > > > > With what frequency are multiple page grants requested? > > You can always use multicalls for batches. In the current usage > scenarios, grant tables are not typically used to map machine > contiguous > regions. > > Ian > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Mark Williamson
2006-Jul-08 13:31 UTC
Re: [Xen-devel] Why gnttab_grant_foreign_access() can only grantaccess for one page?
> There should be a hypercall to grow a domain''s grant table. It''s been on > the todo list for a while. Want to knock something up?I''d be able to review code etc for this, feel free to contact me on or off list. It''ll be useful for my work also. Cheers, Mark> > Thanks, > Ian > > > thanks, > > lily > > > > On 7/7/06, Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk> wrote: > > > Lily Huang wrote: > > > > THis seems to be less efficient. Why cannot we allow this > > > > function > > > > > > to grant access for mulitiple pages just remap function? > > > > > > With what frequency are multiple page grants requested? > > > > You can always use multicalls for batches. In the current usage > > scenarios, grant tables are not typically used to map machine > > contiguous > > regions. > > > > Ian > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel-- Dave: Just a question. What use is a unicyle with no seat? And no pedals! Mark: To answer a question with a question: What use is a skateboard? Dave: Skateboards have wheels. Mark: My wheel has a wheel! _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel