MINAI Katsuhito
2006-Jul-07 08:21 UTC
[Xen-devel] [PATCH] [2/4] put xen console message into syslog but xm dmesg is not affected
[2/4] add xenlogd daemon for xen console logging Signed-off-by: Katsuhito Minai <minai@jp.fujitsu.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Jul-10 15:02 UTC
Re: [Xen-devel] [PATCH] [2/4] put xen console message into syslog but xm dmesg is not affected
On 7 Jul 2006, at 09:21, MINAI Katsuhito wrote:> [2/4] add xenlogd daemon for xen console logging > > Signed-off-by: Katsuhito Minai <minai@jp.fujitsu.com>Let''s not add extra code styles to the tree: either format your code in Xen style (4-space soft tabs; braces on their own lines) or in Linux style (hard tabs; K&R style). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
MINAI Katsuhito
2006-Jul-11 06:41 UTC
Re: [Xen-devel] [PATCH] [2/4] put xen console message into syslog butxm dmesg is not affected
Hi keir I am sorry that the code style of my patch is scattering. After the discussion with you concerning xc_readconsolering() reached a conclusion, I''d like to re-contribute the patch to match the code style of Xen. Best regards, Katsuhito Minai On 11 Jul 2006, at 12:02 am, Keir Fraser said:> > On 7 Jul 2006, at 09:21, MINAI Katsuhito wrote: > >> [2/4] add xenlogd daemon for xen console logging >> >> Signed-off-by: Katsuhito Minai <minai@jp.fujitsu.com> > > Let''s not add extra code styles to the tree: either format your code in > Xen style (4-space soft tabs; braces on their own lines) or in Linux > style (hard tabs; K&R style). > > -- Keir > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Horms
2006-Jul-11 12:30 UTC
[Xen-devel] Re: [PATCH] [2/4] put xen console message into syslog but?xm dmesg is not affected
On Mon, 10 Jul 2006 16:02:16 +0100, Keir Fraser wrote:> > On 7 Jul 2006, at 09:21, MINAI Katsuhito wrote: > >> [2/4] add xenlogd daemon for xen console logging >> >> Signed-off-by: Katsuhito Minai <minai@jp.fujitsu.com> > > Let''s not add extra code styles to the tree: either format your code in > Xen style (4-space soft tabs; braces on their own lines) or in Linux > style (hard tabs; K&R style).Two is already one too many IMHO :-) -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Jul-11 15:13 UTC
[Xen-devel] Re: [PATCH] [2/4] put xen console message into syslog but?xm dmesg is not affected
On 11 Jul 2006, at 13:30, Horms wrote:>> Let''s not add extra code styles to the tree: either format your code >> in >> Xen style (4-space soft tabs; braces on their own lines) or in Linux >> style (hard tabs; K&R style). > > Two is already one too many IMHO :-)As long as each discrete ''tool'' or library is self-consistent in which it picks I don''t really see a problem. In fact I wouldn''t be too bothered about having more than two styles to choose from -- but two-space soft tabs are not an option as far as I''m concerned, which is the main reason I commented. There are more important issues than petty battles over coding standards. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Horms
2006-Jul-12 00:42 UTC
[Xen-devel] Re: [PATCH] [2/4] put xen console message into syslog but?xm dmesg is not affected
On Tue, Jul 11, 2006 at 04:13:01PM +0100, Keir Fraser wrote:> > On 11 Jul 2006, at 13:30, Horms wrote: > > >>Let''s not add extra code styles to the tree: either format your code > >>in > >>Xen style (4-space soft tabs; braces on their own lines) or in Linux > >>style (hard tabs; K&R style). > > > >Two is already one too many IMHO :-) > > As long as each discrete ''tool'' or library is self-consistent in which > it picks I don''t really see a problem. In fact I wouldn''t be too > bothered about having more than two styles to choose from -- but > two-space soft tabs are not an option as far as I''m concerned, which is > the main reason I commented. There are more important issues than petty > battles over coding standards.Sorry, I was niggling a bit. I don''t mind too much either, as long as its clear which directories (or files) use which standard. Though it is a bit of a mind-warp when you have files from xen/ and some kernel files open at the same time. I had to get quite good at teaching my editor what to do for me. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel