Masaki Kanno
2006-Jul-06 16:08 UTC
[Xen-devel] [PATCH] Fix argument check of xm reboot command (3)
Hi, I tested unlikely operations about the xm reboot/shutdown command. As a result, I found the following problems. Problem 1: Can reboot/shutdown Domain-0 by mistake. # xm list Name ID Mem(MiB) VCPUs State Time(s) Domain-0 0 1024 2 r----- 31.0 # xm reboot 0 Error: Can''t specify Domain-0 # xm reboot 00 # Broadcast message from root (console) (Thu Jul 6 23:50:09 2006): The system is going down for reboot NOW! Problem 2: Can not reboot/shutdown domain of domain name ''0''. # xm list Name ID Mem(MiB) VCPUs State Time(s) 0 1 256 1 -b---- 3.5 Domain-0 0 1024 2 r----- 29.8 # xm reboot 0 Error: Can''t specify Domain-0 I fixed these problems with this patch. Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> Best regards, Kan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Jul-10 14:16 UTC
Re: [Xen-devel] [PATCH] Fix argument check of xm reboot command (3)
On 6 Jul 2006, at 17:08, Masaki Kanno wrote:> tested unlikely operations about the xm reboot/shutdown command. > As a result, I found the following problems. > > Problem 1: Can reboot/shutdown Domain-0 by mistake. > Problem 2: Can not reboot/shutdown domain of domain name ''0''.Wouldn''t this be better checked in xend after it has converted domain name to domid, and an appropriate error string returned to the RPC caller? Putting the checking in xm seems a bit unnatural and means that other callers do not benefit. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Masaki Kanno
2006-Jul-11 04:05 UTC
Re: [Xen-devel] [PATCH] Fix argument check of xm reboot command (3)
Hi Keir, Thanks for your comment and advice. I will remake and resend this patch. Best regards, Kan> >On 6 Jul 2006, at 17:08, Masaki Kanno wrote: > >> tested unlikely operations about the xm reboot/shutdown command. >> As a result, I found the following problems. >> >> Problem 1: Can reboot/shutdown Domain-0 by mistake. >> Problem 2: Can not reboot/shutdown domain of domain name ''0''. > >Wouldn''t this be better checked in xend after it has converted domain >name to domid, and an appropriate error string returned to the RPC >caller? Putting the checking in xm seems a bit unnatural and means that >other callers do not benefit. > > -- Keir > > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Masaki Kanno
2006-Jul-28 13:10 UTC
Re: [Xen-devel] [PATCH] [RESEND] Fix argument check of xm reboot command (3)
Hi, I made a patch again. Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> Best regards, Kan> >On 6 Jul 2006, at 17:08, Masaki Kanno wrote: > >> tested unlikely operations about the xm reboot/shutdown command. >> As a result, I found the following problems. >> >> Problem 1: Can reboot/shutdown Domain-0 by mistake. >> Problem 2: Can not reboot/shutdown domain of domain name ''0''. > >Wouldn''t this be better checked in xend after it has converted domain >name to domid, and an appropriate error string returned to the RPC >caller? Putting the checking in xm seems a bit unnatural and means that >other callers do not benefit. > > -- Keir > > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel