Shared libraries are supposed to be installed +x Signed-off-by: Jeremy Katz <katzj@redhat.com> Jeremy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Bastian Blank
2006-Jul-04 06:51 UTC
Re: [Xen-devel] [PATCH] libxenstore should be executable
On Mon, Jul 03, 2006 at 11:28:03PM -0400, Jeremy Katz wrote:> Shared libraries are supposed to be installed +xNo. Most of them can''t be executed. Bastian -- Many Myths are based on truth -- Spock, "The Way to Eden", stardate 5832.3 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Vincent Hanquez
2006-Jul-04 09:57 UTC
Re: [Xen-devel] [PATCH] libxenstore should be executable
On Mon, Jul 03, 2006 at 11:28:03PM -0400, Jeremy Katz wrote:> Shared libraries are supposed to be installed +x > > Signed-off-by: Jeremy Katz <katzj@redhat.com> > > Jeremy> diff -r fd6d12935b56 tools/xenstore/Makefile > --- a/tools/xenstore/Makefile Mon Jul 03 16:07:20 2006 +0100 > +++ b/tools/xenstore/Makefile Mon Jul 03 23:26:44 2006 -0400 > @@ -171,7 +171,7 @@ install: all > $(INSTALL_PROG) xenstore-control $(DESTDIR)/usr/bin > $(INSTALL_PROG) xenstore-ls $(DESTDIR)/usr/bin > $(INSTALL_DIR) -p $(DESTDIR)/usr/$(LIBDIR) > - $(INSTALL_DATA) libxenstore.so $(DESTDIR)/usr/$(LIBDIR) > + $(INSTALL_PROG) libxenstore.so $(DESTDIR)/usr/$(LIBDIR) > $(INSTALL_DATA) xs.h $(DESTDIR)/usr/include > $(INSTALL_DATA) xs_lib.h $(DESTDIR)/usr/includeI don''t think that needed (almost all libraries in my /usr/lib are -x). Even then you shouldn''t call INSTALL_**PROG** but just create an INSTALL_LIB or somethign similar.. -- Vincent Hanquez _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Katz
2006-Jul-05 18:36 UTC
Re: [Xen-devel] [PATCH] libxenstore should be executable
On Tue, 2006-07-04 at 11:57 +0200, Vincent Hanquez wrote:> On Mon, Jul 03, 2006 at 11:28:03PM -0400, Jeremy Katz wrote: > > Shared libraries are supposed to be installed +x > > I don''t think that needed (almost all libraries in my /usr/lib are -x). > Even then you shouldn''t call INSTALL_**PROG** but just create an > INSTALL_LIB or somethign similar..Shared libs have traditionally been installed as executables due to some long ago accidents of implementation in historical Unixes. And there are various tools which "expect" it (... and this is why they get created as executable by default by ld). Switching to INSTALL_LIB here although I think the whole "define all the ways you''re going to use install" in this makefile a _smidge_ overkill Signed-off-by: Jeremy Katz <katzj@redhat.com> Jeremy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, 05 Jul 2006 14:36:29 -0400, Jeremy Katz wrote:> [-- text/plain, encoding 7bit, charset: ISO-8859-1, 20 lines --] > > On Tue, 2006-07-04 at 11:57 +0200, Vincent Hanquez wrote: >> On Mon, Jul 03, 2006 at 11:28:03PM -0400, Jeremy Katz wrote: >> > Shared libraries are supposed to be installed +x >> >> I don''t think that needed (almost all libraries in my /usr/lib are -x). >> Even then you shouldn''t call INSTALL_**PROG** but just create an >> INSTALL_LIB or somethign similar.. > > Shared libs have traditionally been installed as executables due to some > long ago accidents of implementation in historical Unixes. And there > are various tools which "expect" it (... and this is why they get > created as executable by default by ld). > > Switching to INSTALL_LIB here although I think the whole "define all the > ways you''re going to use install" in this makefile a _smidge_ overkill > > Signed-off-by: Jeremy Katz <katzj@redhat.com>I think that this patch is corret (well, perhaps execpt for the _smidge_ bit). I believe that it is general practice for make install and the like to install shared libraries as executables for the reason that you give above. Though it is common practice for distros to remove the executable bit as part of their packaging process - which explains why many people won''t see it when they go and check /usr/lib, but is of little concern to this patch. Acked: Horms <horms@verge.net.au> -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel