Xen devel - Jan 2006 - RE: [Xen-ia64-devel] cset 8690 blk driver regression

These were two separate bugs.  Backing out
(or otherwise rewriting) that patch is still
necessary for domU to boot on ia64.

A gnttab_shared_gpfn macro sounds good to me!
(assuming defined to the pre-patch lines for
ia64 and the post-patch lines for x86?)

Thanks,
Dan
> -----Original Message-----
> From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk] 
> Sent: Tuesday, January 31, 2006 3:33 PM
> To: Magenheimer, Dan (HP Labs Fort Collins)
> Cc: Williamson, Alex (Linux Kernel Dev); 
> xen-ia64-devel@lists.xensource.com; 
> xen-devel@lists.xensource.com; sos22@cam.ac.uk
> Subject: Re: [Xen-ia64-devel] cset 8690 blk driver regression
> 
> 
> On 31 Jan 2006, at 20:11, Magenheimer, Dan (HP Labs Fort 
> Collins) wrote:
> 
> > To fix it so that it works on x86 (shadow and non-shadow)
> > and ia64, perhaps a macro call could be substituted for
> > the three removed lines and define''d differently for each
> > arch in asm/shadow.h?
> 
> I removed the dummy definition of __mfn_to_gpfn() from xen/shadow.h 
> that was hiding ia64''s own definition. I think Alex Williamson
posted
> that as a fix. Is using that macro here not applicable for 
> ia64 at all? 
> If not and the tree is still broken for ia64 then we can 
> perhaps define 
> a gnttab_shared_gpfn() macro.
> 
>   -- Keir
> 
> 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tue, 2006-01-31 at 14:48 -0800, Magenheimer, Dan (HP Labs Fort
Collins) wrote:
> These were two separate bugs.  Backing out
> (or otherwise rewriting) that patch is still
> necessary for domU to boot on ia64.
> 
> A gnttab_shared_gpfn macro sounds good to me!
> (assuming defined to the pre-patch lines for
> ia64 and the post-patch lines for x86?)
   The easiest thing would be making __mfn_to_gpfn() be a pass through
like below.  It works for now, but I don''t know what I''m
breaking by
doing this.  Thanks,

	Alex

diff -r 9ef5f0ec9df8 xen/include/asm-ia64/mm.h
--- a/xen/include/asm-ia64/mm.h Tue Jan 31 17:39:35 2006
+++ b/xen/include/asm-ia64/mm.h Tue Jan 31 10:07:45 2006
@@ -422,8 +422,7 @@
 * here. However if it''s allocated by HV, we should access it directly
 */
 
-#define __mfn_to_gpfn(_d, mfn)                 \
-    machine_to_phys_mapping[(mfn)]
+#define __mfn_to_gpfn(_d, mfn)  (mfn)
 
 #define __gpfn_to_mfn(_d, gpfn)                        \
     __gpfn_to_mfn_foreign((_d), (gpfn))


-- 
Alex Williamson                             HP Linux & Open Source Lab


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 31 Jan 2006, at 23:08, Alex Williamson wrote:
>> These were two separate bugs.  Backing out
>> (or otherwise rewriting) that patch is still
>> necessary for domU to boot on ia64.
>>
>> A gnttab_shared_gpfn macro sounds good to me!
>> (assuming defined to the pre-patch lines for
>> ia64 and the post-patch lines for x86?)
>
>    The easiest thing would be making __mfn_to_gpfn() be a pass through
> like below.  It works for now, but I don''t know what I''m
breaking by
> doing this.  Thanks,
Yeah, that''s probably bad news. gnttab_shared_gpfn sounds better.

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel