Xen devel - Jan 2006 - Re: [Xen-changelog] Export Xen driver util function symbols so that Xen drivers

On Wed, Jan 25, 2006 at 03:12:08PM +0000, Xen patchbot -unstable
wrote:
> # HG changeset patch
> # User kaf24@firebug.cl.cam.ac.uk
> # Node ID 709bce2f08d6024c2efb2938e564915da1ca51f2
> # Parent  aad2b2da3c8beda24bc62ca6e92b28c28def0849
> Export Xen driver util function symbols so that Xen drivers
> can build as modules.
> 
> Signed-off-by: Keir Fraser <keir@xensource.com>
> 
> diff -r aad2b2da3c8b -r 709bce2f08d6
linux-2.6-xen-sparse/drivers/xen/util.c
> --- a/linux-2.6-xen-sparse/drivers/xen/util.c	Wed Jan 25 11:51:21 2006
> +++ b/linux-2.6-xen-sparse/drivers/xen/util.c	Wed Jan 25 13:28:07 2006
> @@ -31,6 +31,7 @@
>  
>  	return area;
>  }
> +EXPORT_SYMBOL(alloc_vm_area);
Should this be EXPORT_SYMBOL_GPL?

Cheers,
Muli
-- 
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, Jan 25, 2006 at 03:36:38PM +0000, Keir Fraser wrote:
> Possibly. Because those functions make use of internal non-exported 
> Linux functions?
That''s one reason, the other is a statement that the authors of this
code are not OK with binary only modules (using it).

Cheers,
Muli
-- 
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 25 Jan 2006, at 15:24, Muli Ben-Yehuda wrote:
>> diff -r aad2b2da3c8b -r 709bce2f08d6 
>> linux-2.6-xen-sparse/drivers/xen/util.c
>> --- a/linux-2.6-xen-sparse/drivers/xen/util.c	Wed Jan 25 11:51:21 2006
>> +++ b/linux-2.6-xen-sparse/drivers/xen/util.c	Wed Jan 25 13:28:07 2006
>> @@ -31,6 +31,7 @@
>>
>>  	return area;
>>  }
>> +EXPORT_SYMBOL(alloc_vm_area);
>
> Should this be EXPORT_SYMBOL_GPL?
Possibly. Because those functions make use of internal non-exported 
Linux functions?

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 25 Jan 2006, at 15:34, Muli Ben-Yehuda wrote:
>> Possibly. Because those functions make use of internal non-exported
>> Linux functions?
>
> That''s one reason, the other is a statement that the authors of
this
> code are not OK with binary only modules (using it).
Personally, I don''t care. Especially for trivial util functions. :-)

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel