Xue, Haifeng
2006-Jan-18 08:58 UTC
[Xen-devel] Clean dirty code avoiding warning messages when compiling
Clean dirty code avoiding warning messages when compiling Signed-off-by: Haifeng Xue <haifeng.xue@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Vincent Hanquez
2006-Jan-18 13:08 UTC
Re: [Xen-devel] Clean dirty code avoiding warning messages when compiling
On Wed, Jan 18, 2006 at 04:58:06PM +0800, Xue, Haifeng wrote:> Clean dirty code avoiding warning messages when compiling > > Signed-off-by: Haifeng Xue <haifeng.xue@intel.com> > > - if (!xs_write(xs, NULL, path, pts, strlen(pts))) { > + if (!xs_write(xs, (xs_transaction_t)NULL, path, pts, strlen(pts))) {Please don''t override the type checking with cast to shut up gcc ! The warning is there for a reason, it should be XBT_NULL instead of NULL. -- Vincent Hanquez _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel