Li, Xin B
2006-Jan-01 22:43 UTC
[Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
Rename VMX option name lapic to apic, and pass it to xen by hvm_info_table. Previous we pass it to xen by guest vcpu context ECX register, now we unify to use hvm_info_table. Signed-off-by: Xin Li <xin.b.li@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Jan-02 10:16 UTC
Re: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
On 1 Jan 2006, at 22:43, Li, Xin B wrote:> Rename VMX option name lapic to apic, and pass it to xen by > hvm_info_table. > Previous we pass it to xen by guest vcpu context ECX register, now we > unify to use hvm_info_table. > > Signed-off-by: Xin Li <xin.b.li@intel.com>I like the name ''lapic'' rather than ''apic'' as it explicitly disambiguates from ''ioapic''. And it''s only one more character. Placing the hvm info definitions in public/io/ioreq.h is not right. It probably needs its own header file. How about a new subdirectory include/public/hvm, containing hvm_info.h, ioreq.h and vmx_assist.h? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Jan-03 11:41 UTC
Re: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
On 2 Jan 2006, at 10:16, Keir Fraser wrote:> I like the name ''lapic'' rather than ''apic'' as it explicitly > disambiguates from ''ioapic''. And it''s only one more character. > > Placing the hvm info definitions in public/io/ioreq.h is not right. It > probably needs its own header file. How about a new subdirectory > include/public/hvm, containing hvm_info.h, ioreq.h and vmx_assist.h?Also, does anything in Xen actually use the nr_vcpus variable? There''s an accessor function for obtaining its value, but noone calls it, nor can I see any reason someone would want to in the future. There''s already a setmaxvcpus dom0_op. Seems the Xen code that reads that part of the hvm_info struct could be removed. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Li, Xin B
2006-Jan-03 12:47 UTC
RE: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
>> Rename VMX option name lapic to apic, and pass it to xen by >> hvm_info_table. >> Previous we pass it to xen by guest vcpu context ECX register, now we >> unify to use hvm_info_table. >> >> Signed-off-by: Xin Li <xin.b.li@intel.com> > >I like the name ''lapic'' rather than ''apic'' as it explicitly >disambiguates from ''ioapic''. And it''s only one more character. >In current implementation, if ''lapic=1'', both lapic and ioapic are enabled for VMX guest, and this is what we prefer. VMX guest has 3 PIC/APIC modes: 1. no lapic and ioapic, only PIC, and this is the default option. 2. both lapic and ioapic, enabled by ''lapic=1'' in VMX config file. 3. only lapic and PIC, no ioapic. No such option, but VMX guest can only use lapic by not using its ioapic. This is the reason why I made this change.>Placing the hvm info definitions in public/io/ioreq.h is not right. It >probably needs its own header file. How about a new subdirectory >include/public/hvm, containing hvm_info.h, ioreq.h and vmx_assist.h? >Yes, I like this new directory for VMX guest using, we do have some structures defined twice. -Xin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Li, Xin B
2006-Jan-03 12:52 UTC
RE: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
>> I like the name ''lapic'' rather than ''apic'' as it explicitly >> disambiguates from ''ioapic''. And it''s only one more character. >> >> Placing the hvm info definitions in public/io/ioreq.h is not >right. It >> probably needs its own header file. How about a new subdirectory >> include/public/hvm, containing hvm_info.h, ioreq.h and vmx_assist.h? > >Also, does anything in Xen actually use the nr_vcpus variable? There''s >an accessor function for obtaining its value, but noone calls it, nor >can I see any reason someone would want to in the future. There''s >already a setmaxvcpus dom0_op. Seems the Xen code that reads that part >of the hvm_info struct could be removed. >SMP VMX guest will use it. Maybe in the future when we have CPU hotplug support in VMX guest, we don''t need it any longer, but that''s need more thoughts :-). -Xin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Li, Xin B
2006-Jan-03 13:23 UTC
RE: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
>>> Placing the hvm info definitions in public/io/ioreq.h is >not right. It >>> probably needs its own header file. How about a new subdirectory >>> include/public/hvm, containing hvm_info.h, ioreq.h and vmx_assist.h? >>> >> >> Yes, I like this new directory for VMX guest using, we do have some >> structures defined twice. > >You''ll send another patch?Yes, could you please check in the previous patch first? I''d like to work on that? Thanks -Xin> > -- Keir >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Jan-03 13:25 UTC
Re: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
On 3 Jan 2006, at 12:47, Li, Xin B wrote:> In current implementation, if ''lapic=1'', both lapic and ioapic are > enabled for VMX guest, and this is what we prefer. > VMX guest has 3 PIC/APIC modes: > 1. no lapic and ioapic, only PIC, and this is the default option. > 2. both lapic and ioapic, enabled by ''lapic=1'' in VMX config file. > 3. only lapic and PIC, no ioapic. No such option, but VMX guest can > only > use lapic by not using its ioapic. > This is the reason why I made this change.Okay, that makes sense.>> Placing the hvm info definitions in public/io/ioreq.h is not right. It >> probably needs its own header file. How about a new subdirectory >> include/public/hvm, containing hvm_info.h, ioreq.h and vmx_assist.h? >> > > Yes, I like this new directory for VMX guest using, we do have some > structures defined twice.You''ll send another patch? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Jan-03 13:42 UTC
Re: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
On 3 Jan 2006, at 13:23, Li, Xin B wrote:>> You''ll send another patch? > > Yes, could you please check in the previous patch first? > I''d like to work on that? > Thanks > -XinOkay. Actually I''ll just move the header files myself as it''s a quick job. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Li, Xin B
2006-Jan-03 13:43 UTC
RE: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
>> Yes, could you please check in the previous patch first? >> I''d like to work on that? >> Thanks >> -Xin > >Okay. Actually I''ll just move the header files myself as it''s a quick >job. >I want to kill all the double definitions by this chance :-) -Xin> -- Keir >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Li, Xin B
2006-Jan-03 14:07 UTC
RE: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
>Done (see changeset 8474 when it appears in the public tree).Thanks a lot! -Xin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Jan-03 14:10 UTC
Re: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
On 3 Jan 2006, at 13:43, Li, Xin B wrote:>> Okay. Actually I''ll just move the header files myself as it''s a quick >> job. >> > > I want to kill all the double definitions by this chance :-) > -XinDone (see changeset 8474 when it appears in the public tree). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel