Dan Smith
2005-Nov-30 21:23 UTC
[Xen-devel] [PATCH] Fix "xm list --long" listing for removed devices
This patch makes xend clean up information about devices at removal so that the long xm listing is consistent with reality. This will close bug #416. Signed-off-by: Dan Smith <danms@us.ibm.com> -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ewan Mellor
2005-Dec-01 18:36 UTC
Re: [Xen-devel] [PATCH] Fix "xm list --long" listing for removed devices
On Wed, Nov 30, 2005 at 01:23:51PM -0800, Dan Smith wrote:> This patch makes xend clean up information about devices at removal so > that the long xm listing is consistent with reality. > > This will close bug #416. > > Signed-off-by: Dan Smith <danms@us.ibm.com>Dan, sorry, but this patch breaks 02_network_attach_detach. Vifs don''t have a ''dev'' entry in their config, so the attempt to read that returns None, which you end up passing to blkdev_name_to_number. In any case, I would rather have the device-specific complexity in the DevController subclasses. If you look at xen/xend/server/blkif.py, it already has to find a device ID from a device name (which in this case it does by looking through the store rather than XendDomainInfo''s config, but the effect is the same). I''d want to keep these things together. I''m not sure how this would all plumb through to XendDomainInfo -- it might be nice to have a mapping from device ID to config so that it wasn''t necessary to iterate over info[''device''] and go grubbing around in the configs there. If you want to re-work this, feel free, otherwise I''ll be taking your basic idea and rejigging it so that the network-detach is not broken, and so that we get that bug fixed in the next day or so. Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Dan Smith
2005-Dec-01 18:43 UTC
Re: [Xen-devel] [PATCH] Fix "xm list --long" listing for removed devices
EM> this patch breaks 02_network_attach_detach. Oops, does it? I ran xm-test over it, but I must have confused that with the other attach-detach test that is failing right now. Sorry about that. EM> In any case, I would rather have the device-specific complexity in EM> the DevController subclasses. Yep, definitely. I was too focused on the block device. Very stupid of me. EM> If you want to re-work this, feel free, otherwise I''ll be taking EM> your basic idea and rejigging it so that the network-detach is not EM> broken, and so that we get that bug fixed in the next day or so. I''ll rework it ASAP. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel