Keir Fraser <Keir.Fraser@cl.cam.ac.uk> wrote on 11/24/2005 05:18:28 AM: > > On 24 Nov 2005, at 04:48, Tony Breeds wrote: > > > Hi All, > > xen/common/acm_ops.c, check for a NULL pointer and then > > cheerfully dereferences it. > > > > Signed-off-by: Tony Breeds <tony@bakeyournoodle.com> > > Applied, but nearby code goto''s out so I changed the patch to do that. > > In fact there seems to be no convention in that function as to whether > returning immediately or goto''ing out (and doing dome return-code > cooking) is the right thing to do. Should all the returns be goto > out''s? I cleaned this file up and elimnated returns inside the switch statement. When we need locks, we can place them now around the switch statement. I also included the comments from Rusty and now return -EPERM for denied permission errors. Thanks Reiner Signed-off: Reiner Sailer <sailer@us.ibm.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel