Magenheimer, Dan (HP Labs Fort Collins)
2005-Nov-15 01:09 UTC
[Xen-devel] FW: [Xen-ia64-devel] [Patch] gcc3.4 build patch
This patch is actually to a file in the x86 tree that ia64 links to. Please apply. HOWEVER... does it make sense to move this file to xen/common/ (or xen/common/vmx) rather than have an ugly cross-arch link? Thanks, Dan> -----Original Message----- > From: xen-ia64-devel-bounces@lists.xensource.com > [mailto:xen-ia64-devel-bounces@lists.xensource.com] On Behalf > Of takebe_akio@jp.fujitsu.com > Sent: Monday, November 14, 2005 5:30 PM > To: xen-ia64-devel@lists.xensource.com > Subject: [Xen-ia64-devel] [Patch] gcc3.4 build patch > > Hi, > > I tried to build xen-ia64-unstable.hg, but I couldn't complie it. > So, I made a gcc3.4 build patch again. > > This patch look like for x86, but it is for ia64 as below. > # ls -l xen/arch/ia64/vmx/vmx_vioapic.c > lrwxrwxrwx 1 root root 34 11月 14 22:33 > xen/arch/ia64/vmx/vmx_vioapic.c > -> ../../../arch/x86/dm/vmx_vioapic.c > > Signed-off-by Akio Takabe <takebe_akio@jp.fujitsu.com> > > Best Regards, > > Akio Takebe > > --------------------- > diff -r bd234c9603ce xen/arch/x86/dm/vmx_vioapic.c > --- a/xen/arch/x86/dm/vmx_vioapic.c Fri Nov 11 19:23:04 2005 > +++ b/xen/arch/x86/dm/vmx_vioapic.c Mon Nov 14 22:52:35 2005 > @@ -209,6 +209,23 @@ > } /* switch */ > } > > +void ioapic_update_EOI(struct domain *d, int vector) > +{ > + vmx_vioapic_t *s = &(d->arch.vmx_platform.vmx_vioapic); > + int redir_num; > + > + if ((redir_num = get_redir_num(s, vector)) == -1) { > + printk("Can't find redir item for %d EOI \n", vector); > + return; > + } > + > + if (!test_and_clear_bit(redir_num, &s->isr)) { > + printk("redir %d not set for %d EOI\n", redir_num, vector); > + return; > + } > +} > + > + > static void vmx_vioapic_write(struct vcpu *v, > unsigned long addr, > unsigned long length, > @@ -557,22 +574,6 @@ > return -1; > } > > -void ioapic_update_EOI(struct domain *d, int vector) > -{ > - vmx_vioapic_t *s = &(d->arch.vmx_platform.vmx_vioapic); > - int redir_num; > - > - if ((redir_num = get_redir_num(s, vector)) == -1) { > - printk("Can't find redir item for %d EOI \n", vector); > - return; > - } > - > - if (!test_and_clear_bit(redir_num, &s->isr)) { > - printk("redir %d not set for %d EOI\n", redir_num, vector); > - return; > - } > -} > - > int vmx_vioapic_add_lapic(struct vlapic *vlapic, struct vcpu *v) > { > vmx_vioapic_t *s = &(v->domain->arch.vmx_platform.vmx_vioapic); > > _______________________________________________ > Xen-ia64-devel mailing list > Xen-ia64-devel@lists.xensource.com > http://lists.xensource.com/xen-ia64-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2005-Nov-15 10:37 UTC
Re: [Xen-devel] FW: [Xen-ia64-devel] [Patch] gcc3.4 build patch
On 15 Nov 2005, at 01:09, Magenheimer, Dan (HP Labs Fort Collins) wrote:> This patch is actually to a file in the x86 tree that ia64 > links to. Please apply.Applied a better one (properly declare the offending function in a header file).> HOWEVER... does it make sense to move this file to > xen/common/ (or xen/common/vmx) rather than have > an ugly cross-arch link?Yeah, at some point. I think we should let things settle a bit and then clean up directory structure and file naming. That''s post 3.0.0 though. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel