here is the 2nd patch. Renato>> -----Original Message----- >> From: Santos, Jose Renato G >> Sent: Friday, November 11, 2005 6:02 PM >> To: Keir Fraser >> Cc: xen-devel@lists.xensource.com; G John Janakiraman; >> Turner, Yoshio; Jose Renato Santos >> Subject: [PATCH] xenoprof (linux-sparse) >> >> >> >> Keir, >> >> I am sending a revised version of xenoprof including a few >> minor fixes and changes based on your comments. >> I was hoping you could push this into the public tree... >> I will be sending the 4 patches in 4 different messages. >> >> Thanks >> >> Renato >>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 12 Nov 2005, at 02:03, Santos, Jose Renato G wrote:> here is the 2nd patch. > RenatoThe Xen patch is pretty big. I''ll break some obvious discrete chunks off it and at least apply those. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Thanks Keir Is there anything I can do to make your job easier? Would you like to receive multiple smaller patches (one patch per file)? Just let me know ... Thanks Renato -----Original Message----- From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk] Sent: Sunday, November 13, 2005 2:33 AM To: Santos, Jose Renato G Cc: Turner, Yoshio; xen-devel@lists.xensource.com; Jose Renato Santos; G John Janakiraman Subject: Re: [PATCH] xenoprof (xen) On 12 Nov 2005, at 02:03, Santos, Jose Renato G wrote:> here is the 2nd patch. > RenatoThe Xen patch is pretty big. I''ll break some obvious discrete chunks off it and at least apply those. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
> Is there anything I can do to make your job easier? > Would you like to receive multiple smaller patches (one patch > per file)?I think we should hold-off applying the linux patches to the sparse tree for the moment for a couple of reasons: John Levon would like to see some cleanups, and I think we''ll be better off applying once the sparse tree has moved to 2.6.14 anyhow (generated from the merge tree). Jose: please could you have a go generating the patch against the linux-2.6-xen.hg tree. Thanks, Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
> -----Original Message----- > From: Ian Pratt [mailto:m+Ian.Pratt@cl.cam.ac.uk] > Sent: Sunday, November 13, 2005 11:24 AM > To: Santos, Jose Renato G; Keir Fraser > Cc: Turner, Yoshio; xen-devel@lists.xensource.com; Jose > Renato Santos; G John Janakiraman; ian.pratt@cl.cam.ac.uk > Subject: RE: [Xen-devel] RE: [PATCH] xenoprof (xen) > > > Is there anything I can do to make your job easier? > > Would you like to receive multiple smaller patches (one patch per > > file)? > > I think we should hold-off applying the linux patches to the > sparse tree for the moment for a couple of reasons: John > Levon would like to see some cleanups, and I think we''ll be > better off applying once the sparse tree has moved to 2.6.14 > anyhow (generated from the merge tree). >Ok, Ian Just a clarification. The cleanups suggested by John Levon, are for the user level tools and for the modifications on the generic code of Oprofile in "drivers/oprofile". Both of these patches are not expected to go into the sparse tree, anyhow. I was expecting that only the changes to "arch/xen/oprofile" would go to the sparse tree. There is no cleanups suggested by John Levon for this patch. From your message, I am assuming that you are agreeing to include the "arch/xen/oprofile" modifications into the sparse tree when it moves to the 2.6.14 (please, correct it if I am wrong). Any expectation of when this should happen? In the mean time, I will be working on the cleanups suggested by John for the user level tools and for generic Oprofile code modifications.> Jose: please could you have a go generating the patch against > the linux-2.6-xen.hg tree. >Forgive me, but I am not sure I understand what you mean in this sentence. Could you please clarify ... Thanks Renato> Thanks, > Ian >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
> From your message, I am assuming that you are agreeing to > include the > "arch/xen/oprofile" modifications into the sparse tree when > it moves to the 2.6.14 (please, correct it if I am wrong). > Any expectation of when this should happen?Well, arch/xen won''t exist as xen is a subarch of i386/x86_64 in our 2.6.14 tree. See http://xenbits.xensource.com/linux-2.6-xen.hg This will replace the 2.6.12 in the xen repository at some point, after more testing. Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian, Oh, I see. I did not know about this reorganization of the xen/linux tree. Do you prefer that I port the xenoprof patch into the "linux-2.6-xen.hg" tree right now or wait for when the tree goes into the xen repository? Thanks Renato> -----Original Message----- > From: Ian Pratt [mailto:m+Ian.Pratt@cl.cam.ac.uk] > Sent: Sunday, November 13, 2005 4:18 PM > To: Santos, Jose Renato G; Keir Fraser; John Levon > Cc: Turner, Yoshio; xen-devel@lists.xensource.com; Jose > Renato Santos; G John Janakiraman; ian.pratt@cl.cam.ac.uk > Subject: RE: [Xen-devel] RE: [PATCH] xenoprof (xen) > > > From your message, I am assuming that you are agreeing to include > > the > > "arch/xen/oprofile" modifications into the sparse tree when > > it moves to the 2.6.14 (please, correct it if I am wrong). > > Any expectation of when this should happen? > > Well, arch/xen won''t exist as xen is a subarch of i386/x86_64 in our > 2.6.14 tree. > > See http://xenbits.xensource.com/linux-2.6-xen.hg > > > This will replace the 2.6.12 in the xen repository at some > point, after more testing. > > Ian >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
> Oh, I see. I did not know about this reorganization of the > xen/linux tree. > Do you prefer that I port the xenoprof patch into the > "linux-2.6-xen.hg" tree right now or wait for when the tree > goes into the xen repository?Yes, please. Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian, Keir Here are the xenoprof patches for the linux-2.6-xen.hg tree. John Levon has reviewed these patches and I have included all his suggestions on this version. According to John, it is unlikely to have these patches included into main stream linux until Xen is also included. I am not sure how would you like to distribute it for now. I suggest that we include the architecture specific driver for xen (xenoprof-arch-linux-2.6.14.patch) into the linux sparse-tree for 2.6.14 (all code in this patch is under arch/i386/xen); and include the generic oprofile driver modifications (xenoprof-generic-linux-2.6.14) in the patches automatically applied when builting the linux trees for xen (all code in this patch are under drivers/oprofile and include/linux). Please let me know if this is acceptable or if you prefer an alternative approach? Thanks Renato>> -----Original Message----- >> From: Ian Pratt [mailto:m+Ian.Pratt@cl.cam.ac.uk] >> Sent: Sunday, November 13, 2005 11:24 AM >> To: Santos, Jose Renato G; Keir Fraser >> Cc: Turner, Yoshio; xen-devel@lists.xensource.com; Jose >> Renato Santos; G John Janakiraman; ian.pratt@cl.cam.ac.uk >> Subject: RE: [Xen-devel] RE: [PATCH] xenoprof (xen) >> >> >> > Is there anything I can do to make your job easier? >> > Would you like to receive multiple smaller patches (one patch >> > per file)? >> >> I think we should hold-off applying the linux patches to the >> sparse tree for the moment for a couple of reasons: John >> Levon would like to see some cleanups, and I think we''ll be >> better off applying once the sparse tree has moved to 2.6.14 >> anyhow (generated from the merge tree). >> >> Jose: please could you have a go generating the patch >> against the linux-2.6-xen.hg tree. >> >> Thanks, >> Ian >>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir, Here is a revised xenoprof patch for xen. It includes some minor fixes I did this week. I checked the latest changesets and have not seen the xenoprof patch in the public tree yet. When applying please use this latest version Thanks Renato>> -----Original Message----- >> From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk] >> Sent: Sunday, November 13, 2005 2:33 AM >> To: Santos, Jose Renato G >> Cc: Turner, Yoshio; xen-devel@lists.xensource.com; Jose >> Renato Santos; G John Janakiraman >> Subject: Re: [PATCH] xenoprof (xen) >> >> >> >> On 12 Nov 2005, at 02:03, Santos, Jose Renato G wrote: >> >> > here is the 2nd patch. >> > Renato >> >> The Xen patch is pretty big. I''ll break some obvious discrete chunks >> off it and at least apply those. >> >> -- Keir >> >>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, Nov 23, 2005 at 05:44:16PM -0800, Santos, Jose Renato G wrote:> John Levon has reviewed these patches and I have included all his > suggestions on this version.To clarify, I''ve only reviewed the first one so far (xenoprof-generic-linux-2.6.14.patch). I still have outstanding issues with the arch one. regards, john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
> -----Original Message----- > From: John Levon [mailto:levon@movementarian.org > Sent: Wednesday, November 23, 2005 6:52 PM > To: Santos, Jose Renato G > Cc: Ian Pratt; Keir Fraser; Jose Renato Santos; > xen-devel@lists.xensource.com; G John Janakiraman; Turner, Yoshio > Subject: Re: [Xen-devel] RE: [PATCH] xenoprof (xen) > > On Wed, Nov 23, 2005 at 05:44:16PM -0800, Santos, Jose Renato G wrote: > > > John Levon has reviewed these patches and I have included all his > > suggestions on this version. > > To clarify, I''ve only reviewed the first one so far > (xenoprof-generic-linux-2.6.14.patch). I still have > outstanding issues with the arch one.Not quite correct. You reviewed both patches and I thought I have addressed all your concerns but apparently there are still some pending issues on the arch patch. Will work on these after the Thanksgiving holiday. Regards Renato> > regards, > john >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel