Puthiyaparambil, Aravindh
2005-Nov-09 20:03 UTC
[Xen-devel] [PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains
Signed off by Aravindh Puthiyaparambil <aravindh.puthiyaparambil@unisys.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2005-Nov-10 08:41 UTC
Re: [Xen-devel] [PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains
I disagree to that. Instead (even in the main kernel, and also on i386) nmi_callback should completely go away, and the supposedly one user should instead use the DIE_NMI and/or DIE_NMI_IPI notifiers. Jan>>> "Puthiyaparambil, Aravindh" <aravindh.puthiyaparambil@unisys.com>09.11.05 21:03:45 >>> Signed off by Aravindh Puthiyaparambil <aravindh.puthiyaparambil@unisys.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Andi Kleen
2005-Nov-10 13:07 UTC
Re: [Xen-devel] [PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains
On Thursday 10 November 2005 09:41, Jan Beulich wrote:> I disagree to that. Instead (even in the main kernel, and also on i386) > nmi_callback should completely go away, and the supposedly one user > should instead use the DIE_NMI and/or DIE_NMI_IPI notifiers.I agree with Jan on that. Haven''t see the original patch, but normally it''s Linux policy to not merge EXPORT_SYMBOLs if there are no modular users of the symbol in tree. -Andi _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Puthiyaparambil, Aravindh
2005-Nov-10 15:11 UTC
RE: [Xen-devel] [PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains
> On Thursday 10 November 2005 09:41, Jan Beulich wrote: > > I disagree to that. Instead (even in the main kernel, and also oni386)> > nmi_callback should completely go away, and the supposedly one user > > should instead use the DIE_NMI and/or DIE_NMI_IPI notifiers.I submitted the patch only because I found that the nmi_callback functions were being exported in all kernels except the Xen x86_64 one. I did not realize that they are going away. We are using the functions in one of our internal modules and I will look into moving away from using them.> Haven''t see the original patch, but normally it''s Linux policy > to not merge EXPORT_SYMBOLs if there are no modular > users of the symbol in tree.I am a little confused here. If that''s the case, then why are the nmi_callback symbols being exported in all kernels but the Xen x86_64 one? I see that it is also being exported in the SLES9 SP2 kernel. Thanks, Aravindh _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel