Ian Pratt
2005-Nov-09 10:48 UTC
RE: [Xen-devel] [PATCH] remove use of get_gendisk in blkfront
> On Fri, 2005-09-02 at 16:28 +0800, Xiaofeng Ling wrote: > > remove use of get_gendisk in blkfront > > gen_gendisk is no long exported by 2.6 kernel. this patch > remove the > > call of get_gendisk by saving the gd point in blkfront_info > in vbd.c > > so that blkfront can be built as kerenl module. > > > > Signed-off-by: Xiaofeng Ling <xiaofeng.ling@intel.com> > > This looks correct to me and helps in building blkfront as a module. > Any chance of getting it committed? I''ve gone ahead and > rediffed against the current tip and cleaned up the warnings. > Attached here.Looks good to me -- AFAIK it was only dropped by accident first time around. Folks: if you submit a patch for inclusion please keep resending every 48h until you get some kind of response or it''s committed. [Aside: it would be really nice if there was some tool that pulled patches off a mailing list and fed them into something like bugzilla, along with all the coments associated with a patch. It should also watch the changelog list and update the status as ''APPLIED'' when appropriate. At any time an author could withdraw/supercede a patch, and a maintainer could reject/keep-on-file. A really smart system would also keep patches fresh by trying to rebase them, or at least note if they still apply cleanly.] Thanks, Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Josh Boyer
2005-Nov-09 13:59 UTC
Re: [Xen-devel] [PATCH] remove use of get_gendisk in blkfront
On 11/9/05, Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk> wrote:> > [Aside: it would be really nice if there was some tool that pulled > patches off a mailing list and fed them into something like bugzilla, > along with all the coments associated with a patch. It should also watch > the changelog list and update the status as ''APPLIED'' when appropriate. > At any time an author could withdraw/supercede a patch, and a maintainer > could reject/keep-on-file. A really smart system would also keep patches > fresh by trying to rebase them, or at least note if they still apply > cleanly.]Jeremy Kerr wrote a tool called patchwork that sort of does that. It''s not nearly as full featured as you''d like, but the basic idea is there. The project page is at: http://www.ozlabs.org/~jk/projects/patchwork/ And an example of it running is at: http://patchwork.ozlabs.org/linuxppc64/ josh _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel