Enable xm console for vmx guest. When the serial port is redirect to pty, write the allocated device to xenstore, then xm console can get it. TODO:serial port by pty shall not block if there are no reading on the other end Signed-off-by: Xiaofeng Ling <xiaofeng.ling@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Daniel Stekloff
2005-Nov-07 06:10 UTC
Re: [Xen-devel] [PATCH] enable xm console for vmx guest
On Sunday 06 November 2005 18:45, Ling, Xiaofeng wrote:> Enable xm console for vmx guest. > When the serial port is redirect to pty, write the allocated > device to xenstore, then xm console can get it. > TODO:serial port by pty shall not block if there are no reading > on the other end > > Signed-off-by: Xiaofeng Ling <xiaofeng.ling@intel.com>Hi, I believe that you must free() path in store_console_dev() when you''re done with it: from xs.h: /* Query the home path of a domain. Call free() after use. */ char *xs_get_domain_path(struct xs_handle *h, unsigned int domid); Thanks, Dan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ling Xiaofeng
2005-Nov-07 13:18 UTC
Re: [Xen-devel] [PATCH] enable xm console for vmx guest
Yes, thanks for pointing out. I''ve updated in the attach patch. ----- Original Message ----- From: "Daniel Stekloff" <dsteklof@us.ibm.com> To: <xen-devel@lists.xensource.com> Cc: "Ling, Xiaofeng" <xiaofeng.ling@intel.com> Sent: Monday, November 07, 2005 2:10 PM Subject: Re: [Xen-devel] [PATCH] enable xm console for vmx guest> On Sunday 06 November 2005 18:45, Ling, Xiaofeng wrote: > > Enable xm console for vmx guest. > > When the serial port is redirect to pty, write the allocated > > device to xenstore, then xm console can get it. > > TODO:serial port by pty shall not block if there are no reading > > on the other end > > > > Signed-off-by: Xiaofeng Ling <xiaofeng.ling@intel.com> > > Hi, > > I believe that you must free() path in store_console_dev() when you''redone> with it: > > from xs.h: > > /* Query the home path of a domain. Call free() after use. > */ > char *xs_get_domain_path(struct xs_handle *h, unsigned int domid); > > Thanks, > > Dan > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel