Magenheimer, Dan (HP Labs Fort Collins)
2005-Nov-04 17:31 UTC
[Xen-devel] Remaining ia64 differences in xen driver code
Hi Keir -- I''ve continued trimming the ia64 differences from various xen driver modules and have it down to a handful. This last round required adding a few #include lines, a couple of calls to xen_init(), and a few ia64 defines (see cset 7514 in http://xenbits.xensource.com/ext/xen-ia64-unstable.hg) and will be in the next ia64 pull. A handful of ia64 differences remain. Since: - we don''t have a good way to split out driver arch-dep differences into a separate file (as is done with xen/common vs xen/arch) other than moving code into header files - remaining changes would require some Xen/x86 code movement - 3.0 freeze is nearing and moving code around is potentially dangerous ...I''d like to move the remaining handful of ia64 differences into the mainline using "#ifdef __ia64__". Would that be OK? If so, I will include them in the next ia64 pull. If not, I''d appreciate some help with the x86 code changes. Thanks, Dan P.S. If you want to look at the specific ifdefs, they can be found in: http://xenbits.xensource.com/ext/xen-ia64-unstable.hg?cmd=manifest;manif est=d2459f19e52e7402572d1a22f3305a9584e6adae;path=/linux-2.6-xen-sparse/ arch/ia64/xen/drivers/patches/ (If this URL gets mangled, go to: http://xenbits.xensource.com/ext/xen-ia64-unstable.hg and walk the manifest to linux-2.6-xen-sparse/arch/ia64/xen/drivers/patches) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hollis Blanchard
2005-Nov-04 19:12 UTC
Re: [Xen-devel] Remaining ia64 differences in xen driver code -- privcmd
On Friday 04 November 2005 11:31, Magenheimer, Dan (HP Labs Fort Collins) wrote:> ...I''d like to move the remaining handful of ia64 differences > into the mainline using "#ifdef __ia64__". Would that > be OK? If so, I will include them in the next ia64 pull. > If not, I''d appreciate some help with the x86 code changes.I have also had to hack up privcmd.c for PowerPC. (It''s not at all "done", but if you''re curious you can see http://xenbits.xensource.com/ext/linux-ppc-2.6.hg?cmd=file;filenode=2d94a3add83d64fa65e574dffbcb9a7cebea5c4b;file=drivers/xen/privcmd/privcmd.c .) It would be cleaner to have privcmd_ioctl just call out to arch_privcmd_ioctl. For example, PPC Linux doesn''t do physical<->machine translation right now. We will probably change that in the future, but for the moment things like ''machine_to_phys_mapping'' do not exist. It seems from your ifdefs that IA64 has similar issues, so for now it seems there are more differences than commonality in privcmd_ioctl, so we should just make it arch-specific. -- Hollis Blanchard IBM Linux Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hollis Blanchard
2005-Nov-04 19:37 UTC
Re: [Xen-devel] Remaining ia64 differences in xen driver code -- gnttab.c
On Friday 04 November 2005 11:31, Magenheimer, Dan (HP Labs Fort Collins) wrote:> > ...I''d like to move the remaining handful of ia64 differences > into the mainline using "#ifdef __ia64__". Would that > be OK? If so, I will include them in the next ia64 pull. > If not, I''d appreciate some help with the x86 code changes.>http://xenbits.xensource.com/ext/xen-ia64-unstable.hg?cmd=file;filenode=b17d1bcf18dae261f40d203a38e1d515a770903c;file=linux-2.6-xen-sparse/arch/ia64/xen/drivers/patches/gnttab.c.patch gnttab.c seems broken. Judging by privcmd.c, that ioctl code won''t work at all on x86-64 even. Mail from yesterday ("Subject: Re: [Xen-devel] Question on xc_gnttab_map_grant_ref()") confirms this. I guess that whole ioctl function should just be removed... -- Hollis Blanchard IBM Linux Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2005-Nov-05 10:05 UTC
Re: [Xen-devel] Remaining ia64 differences in xen driver code
This is fine by me. -- Keir On 4 Nov 2005, at 17:31, Magenheimer, Dan (HP Labs Fort Collins) wrote:> Hi Keir -- > > I''ve continued trimming the ia64 differences from various > xen driver modules and have it down to a handful. This last > round required adding a few #include lines, a couple of calls > to xen_init(), and a few ia64 defines (see cset 7514 in > http://xenbits.xensource.com/ext/xen-ia64-unstable.hg) and > will be in the next ia64 pull. > > A handful of ia64 differences remain. Since: > > - we don''t have a good way to split out driver arch-dep > differences into a separate file (as is done with > xen/common vs xen/arch) other than moving code into > header files > - remaining changes would require some Xen/x86 code movement > - 3.0 freeze is nearing and moving code around is potentially > dangerous > > ...I''d like to move the remaining handful of ia64 differences > into the mainline using "#ifdef __ia64__". Would that > be OK? If so, I will include them in the next ia64 pull. > If not, I''d appreciate some help with the x86 code changes. > > Thanks, > Dan > > P.S. If you want to look at the specific ifdefs, they can be > found in: > > http://xenbits.xensource.com/ext/xen-ia64-unstable.hg?cmd=manifest; > manif > est=d2459f19e52e7402572d1a22f3305a9584e6adae;path=/linux-2.6-xen- > sparse/ > arch/ia64/xen/drivers/patches/ > > (If this URL gets mangled, go to: > http://xenbits.xensource.com/ext/xen-ia64-unstable.hg > and walk the manifest to > linux-2.6-xen-sparse/arch/ia64/xen/drivers/patches) > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel