Xen devel - Oct 2005 - [Fwd: [Xen-changelog] Fix Jerone Young''s xenstat / xenstore patch:]

Hi Ewan,

Wouldn''t it be better, instead of getting rid of the domid code in
xentop.c, to make an option to view domain id that isn''t on by default?
Wouldn''t it be useful to have access to domid? XM commands use domid
and
not names. Why have xentop only work with names?

Thanks,

Dan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Thu, Oct 27, 2005 at 09:04:55AM -0700, Daniel Stekloff wrote:
> 
> Hi Ewan,
> 
> Wouldn''t it be better, instead of getting rid of the domid code in
> xentop.c, to make an option to view domain id that isn''t on by
default?
> Wouldn''t it be useful to have access to domid? XM commands use
domid and
> not names. Why have xentop only work with names?
I don''t think there''s any xm command that doesn''t
work with names -- every
command should be able to run either with a name or a dom ID.  That said, I
would have no problem with an option to xentop to show the ID rather than the
name, and if you wanted to submit a patch, then that would be great.

Cheers,

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Thu, 2005-10-27 at 17:13 +0100, Ewan Mellor wrote:
> On Thu, Oct 27, 2005 at 09:04:55AM -0700, Daniel Stekloff wrote:
> 
> > 
> > Hi Ewan,
> > 
> > Wouldn''t it be better, instead of getting rid of the domid
code in
> > xentop.c, to make an option to view domain id that isn''t on
by default?
> > Wouldn''t it be useful to have access to domid? XM commands
use domid and
> > not names. Why have xentop only work with names?
> 
> I don''t think there''s any xm command that
doesn''t work with names -- every
> command should be able to run either with a name or a dom ID.  That said, I
> would have no problem with an option to xentop to show the ID rather than
the
> name, and if you wanted to submit a patch, then that would be great.

Heh... I didn''t know that domain name could be switched with domain id.
My bad. I''ve included a small patch to add a comment to the xm help
messages. Is there an xm man page, which is referenced in the help
message? If this still needs to be written, I can certainly take a stab
at it.

I''ll send a patch for xentop.

Thanks for your help,

Dan


Signed-off-by: Daniel Stekloff <dsteklof@us.ibm.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Thu, Oct 27, 2005 at 10:11:46AM -0700, Daniel Stekloff wrote:
> Heh... I didn''t know that domain name could be switched with
domain id.
> My bad. I''ve included a small patch to add a comment to the xm
help
> messages. Is there an xm man page, which is referenced in the help
> message? If this still needs to be written, I can certainly take a stab
> at it.
As far as I know, those references to man pages are big fat lies, and it would
be very useful if you could write some.  I think that the command list in
xm/main.py is pretty much up to date, so that''s a good starting point,
but
it''s worth checking them, obviously.

Thanks,

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> As far as I know, those references to man pages are big fat lies, and it
> would be very useful if you could write some.  I think that the command
> list in xm/main.py is pretty much up to date, so that''s a good
starting
> point, but it''s worth checking them, obviously.
*even* nicer would be to have a Python script that groks through main.py and 
*generates* an up-to-date man page based on some template text, adding the 
help text for the current commands.

Non-live documentation tends to get broken very quickly, so anything that can 
be semi-automatically rebuilt is a definite plus.

Cheers,
Mark

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Thu, Oct 27, 2005 at 11:24:25PM +0100, Ewan Mellor
wrote:
> On Thu, Oct 27, 2005 at 10:11:46AM -0700, Daniel Stekloff wrote:
> 
> > Heh... I didn''t know that domain name could be switched with
domain id.
> > My bad. I''ve included a small patch to add a comment to the
xm help
> > messages. Is there an xm man page, which is referenced in the help
> > message? If this still needs to be written, I can certainly take a
stab
> > at it.
> 
> As far as I know, those references to man pages are big fat lies, and it
would
> be very useful if you could write some.  I think that the command list in
> xm/main.py is pretty much up to date, so that''s a good starting
point, but
> it''s worth checking them, obviously.
I''ve got some man page content that I submitted as a patch over the
summer,
but it never went in (presumably because I was using POD).  If there is a
general agreed to easy format for adding content (i.e. POD or asciidoc that
mercurial uses), I''ll resumbit that content.

	-Sean

-- 
__________________________________________________________________

Sean Dague                                       Mid-Hudson Valley
sean at dague dot net                            Linux Users Group
http://dague.net                                 http://mhvlug.org

There is no silver bullet.  Plus, werewolves make better neighbors
than zombies, and they tend to keep the vampire population down.
__________________________________________________________________


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, Oct 28, 2005 at 12:41:29AM +0100, Mark Williamson
wrote:
> > As far as I know, those references to man pages are big fat lies, and
it
> > would be very useful if you could write some.  I think that the
command
> > list in xm/main.py is pretty much up to date, so that''s a
good starting
> > point, but it''s worth checking them, obviously.
> 
> *even* nicer would be to have a Python script that groks through main.py
and
> *generates* an up-to-date man page based on some template text, adding the 
> help text for the current commands.
> 
> Non-live documentation tends to get broken very quickly, so anything that
can
> be semi-automatically rebuilt is a definite plus.
Except formatting kind of blows in those cases.  Even hg uses off line text
to generate it''s man pages.

The other nice thing is you can more easily get people working on doc bugs
without submitting patches that touch code.

	-Sean

-- 
__________________________________________________________________

Sean Dague                                       Mid-Hudson Valley
sean at dague dot net                            Linux Users Group
http://dague.net                                 http://mhvlug.org

There is no silver bullet.  Plus, werewolves make better neighbors
than zombies, and they tend to keep the vampire population down.
__________________________________________________________________


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> > Non-live documentation tends to get broken very quickly, so anything
that
> > can be semi-automatically rebuilt is a definite plus.
>
> Except formatting kind of blows in those cases.  Even hg uses off line text
> to generate it''s man pages.
Actually, I think Matt wants to move to autogenerating the manpages for hg.  
It doesn''t have to cause formatting issues either - it''s not
that difficult
to just parse blocks of help text if they''re sensibly structured.  Or
you
could go the "direct" route of writing the "generator"
script in Python and
accessing the strings directly (*evil grin*).
> The other nice thing is you can more easily get people working on doc bugs
> without submitting patches that touch code.
Equally well, many of the doc bugs *come* from patches that touch code, 
causing the docs to become wrong ;-)

Anyhow if the docs get well maintained by someone it doesn''t really
matter how
it happens.

Cheers,
Mark

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel