Scott Parish
2005-Oct-14 17:12 UTC
[Xen-devel] [patch] PFN_PHYS PAE overflow (fixes bug 242)
machine_specific_memory_setup() makes the following call to setup e820:
add_memory_region(0, PFN_PHYS(max_pfn), E820_RAM);
Since max_pfn is (rightly) an unsigned long, we overflow for the current
definition of PFN_PHYS. Attached is my preferred solution as it will
hopefully avoid similar situations that may come up in the future.
sRp
--
Scott Parish
Signed-off-by: srparish@us.ibm.com
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Pratt
2005-Oct-14 22:55 UTC
RE: [Xen-devel] [patch] PFN_PHYS PAE overflow (fixes bug 242)
> machine_specific_memory_setup() makes the following call to > setup e820: > > add_memory_region(0, PFN_PHYS(max_pfn), E820_RAM); > > Since max_pfn is (rightly) an unsigned long, we overflow for > the current definition of PFN_PHYS. Attached is my preferred > solution as it will hopefully avoid similar situations that > may come up in the future.Good catch! Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel