Now that we have proper 16-bit bootstrap support (in the form of vmxassist/vmxloader), I assume there is no need or advantage to directly boot native Linux kernels from xc_vmx_build? If this is the case, can we please strip all the Linux-specific stuff (mainly the Linux-specific boot parameters) out of xc_vmx_build.c? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
>Now that we have proper 16-bit bootstrap support (in the form of >vmxassist/vmxloader), I assume there is no need or advantage to >directly boot native Linux kernels from xc_vmx_build? > >If this is the case, can we please strip all the Linux-specific stuff >(mainly the Linux-specific boot parameters) out of xc_vmx_build.c?Hmm, how about keeping it there, and only compiling when in debug mode? It''s possible for advanced user for debugging. -Xin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 20 Sep 2005, at 14:22, Li, Xin B wrote:> Hmm, how about keeping it there, and only compiling when in debug mode? > It''s possible for advanced user for debugging.It''s quite a lot of code for no really good purpose. I''d rather get rid of it unless it really is commonly useful for debugging. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
> >It''s quite a lot of code for no really good purpose. I''d >rather get rid >of it unless it really is commonly useful for debugging.Yes, agree now! -Xin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser wrote:> Now that we have proper 16-bit bootstrap support (in the form of > vmxassist/vmxloader), I assume there is no need or advantage to > directly boot native Linux kernels from xc_vmx_build? > > If this is the case, can we please strip all the Linux-specific stuff > (mainly the Linux-specific boot parameters) out of xc_vmx_build.c? > > -- KeirYes, xc_vmx_build.c should be OS-agnostic, and those Linux-specific stuff should be removed. It''s not good for Linux, either. Jun --- Intel Open Source Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
>> If this is the case, can we please strip all the Linux-specific stuff >> (mainly the Linux-specific boot parameters) out of xc_vmx_build.c? >> >> -- Keir > >Yes, xc_vmx_build.c should be OS-agnostic, and those >Linux-specific stuff should be removed. It''s not good for >Linux, either.So we will send a patch for that. -Xin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ling, Xiaofeng
2005-Sep-20 15:12 UTC
RE: [Xen-devel] RE: linux_boot_params in the vmx builder
If we want to have the feature of start vmx guest from a vbd disk and mount it as root file system. Then we''d better keep the current function of loading kernel directly. Nakajima, Jun <> wrote:> Keir Fraser wrote: >> Now that we have proper 16-bit bootstrap support (in the form of >> vmxassist/vmxloader), I assume there is no need or advantage to >> directly boot native Linux kernels from xc_vmx_build? >> >> If this is the case, can we please strip all the Linux-specific stuff >> (mainly the Linux-specific boot parameters) out of xc_vmx_build.c? >> >> -- Keir > > Yes, xc_vmx_build.c should be OS-agnostic, and those Linux-specific > stuff should be removed. It''s not good for Linux, either. > > Jun > --- > Intel Open Source Technology Center > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 20 Sep 2005, at 15:50, Li, Xin B wrote:>> Yes, xc_vmx_build.c should be OS-agnostic, and those >> Linux-specific stuff should be removed. It''s not good for >> Linux, either. > > So we will send a patch for that.I think you should be able to get rid of: 1. Linux boot params 2. e820 map 3. vboot_gdt Should make xc_vmx_build a *lot* smaller. :-) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2005-Sep-20 16:20 UTC
Re: [Xen-devel] RE: linux_boot_params in the vmx builder
On 20 Sep 2005, at 16:12, Ling, Xiaofeng wrote:> If we want to have the feature of start vmx guest from a vbd disk > and mount it as root file system. Then we''d better keep the current > function > of loading kernel directly.We''ll get this back when ioemu is moved out of domain0, and all domains (paravirt and vmx) use the common vbd blkback infrastructure. It''s okay to lose it for now imo: I''d much rather see a patch to rip all this stuff out of xc_vmx_build. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kamble, Nitin A
2005-Sep-21 20:10 UTC
RE: [Xen-devel] Re: linux_boot_params in the vmx builder
Keir.>I think you should be able to get rid of: > 1. Linux boot paramsI believe this should be removable.> 2. e820 mapThis can not be removed, because all the VMX guests (even non-linux) needs the mem-map which isoptained by BIOS call e820.> 3. vboot_gdtThis atleast should be movable to vmxloader. Thanks & Regards, Nitin ------------------------------------------------------------------------ ----------- Open Source Technology Center, Intel Corp>-----Original Message----- >From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel- >bounces@lists.xensource.com] On Behalf Of Keir Fraser >Sent: Tuesday, September 20, 2005 9:15 AM >To: Li, Xin B >Cc: Jiang, Yunhong; Li, Chengyuan; xen-devel List; Nakajima, Jun >Subject: [Xen-devel] Re: linux_boot_params in the vmx builder > > >On 20 Sep 2005, at 15:50, Li, Xin B wrote: > >>> Yes, xc_vmx_build.c should be OS-agnostic, and those >>> Linux-specific stuff should be removed. It''s not good for >>> Linux, either. >> >> So we will send a patch for that. > >I think you should be able to get rid of: > 1. Linux boot params > 2. e820 map > 3. vboot_gdt > >Should make xc_vmx_build a *lot* smaller. :-) > > -- Keir > > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
>>> 2. e820 map >> This can not be removed, because all the VMX guests (even >> non-linux) needs the mem-map which isoptained by BIOS call e820. > >Okay, but there''s no need to embed it as a linux boot param any more. >Maybe it can be moved to a less ''magic'' location than 0x902D0. >Yes, the code is ready, but need cleanup. -Xin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2005-Sep-22 09:58 UTC
Re: [Xen-devel] Re: linux_boot_params in the vmx builder
On 21 Sep 2005, at 21:10, Kamble, Nitin A wrote:>> 2. e820 map > This can not be removed, because all the VMX guests (even > non-linux) needs the mem-map which isoptained by BIOS call e820.Okay, but there''s no need to embed it as a linux boot param any more. Maybe it can be moved to a less ''magic'' location than 0x902D0. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel