Xen devel - Sep 2005 - [PATCH] Fix another race condition in xm destroy

There''s a race condition in xm destroy that gets triggered when 
xc_domain_destroy results in a domain disappearing before we invoke the 
cleanup routines.  Specifically, the saveToDB routines will through a No 
such process error.

Christian, I''d appreciate if you could sanity check this before 
committing.  I think it''s okay because starting the cleanup
shouldn''t
have any adverse effects.  Having another pair of eyes confirm it would 
make me feel better though :-)

BTW, this is not the fix for the xm destroy && xm create race 
condition.  Just another one I found in the process.

Regards,

Anthony Liguori


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 9/16/05, Anthony Liguori <aliguori@us.ibm.com>
wrote:
> There''s a race condition in xm destroy that gets triggered when
> xc_domain_destroy results in a domain disappearing before we invoke the
> cleanup routines.  Specifically, the saveToDB routines will through a No
> such process error.
> 
> Christian, I''d appreciate if you could sanity check this before
> committing.  I think it''s okay because starting the cleanup
shouldn''t
> have any adverse effects.  Having another pair of eyes confirm it would
> make me feel better though :-)
How does it fail for you?  I fixed one issue where we were clearing
the store event channel and writing that back to the store was
failing.

I''d prefer to keep doing the cleanup after destroy_domain.

     christian

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Christian Limpach wrote:
>On 9/16/05, Anthony Liguori <aliguori@us.ibm.com> wrote:
>  
>
>>There''s a race condition in xm destroy that gets triggered when
>>xc_domain_destroy results in a domain disappearing before we invoke the
>>cleanup routines.  Specifically, the saveToDB routines will through a No
>>such process error.
>>
>>Christian, I''d appreciate if you could sanity check this before
>>committing.  I think it''s okay because starting the cleanup
shouldn''t
>>have any adverse effects.  Having another pair of eyes confirm it would
>>make me feel better though :-)
>>    
>>
>
>How does it fail for you?  I fixed one issue where we were clearing
>the store event channel and writing that back to the store was
>failing.
>  
>
You''re fix solved the problem.  That''s why I made sure to ask,
I wasn''t
confident my solution was correct :-)

Thanks,

Anthony Liguori
>I''d prefer to keep doing the cleanup after destroy_domain.
>
>     christian
>
>  
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel