Xen devel - Sep 2005 - Fix blatant non-archdep''isms... need help with build env change?

There are a couple of files in sparse/include/asm-xen
that should be portable to other arch''s but
are blatantly x86-only.  I was going to post
a patch to fix these but I don''t see an easy
way to modify mkbuildtree to point to the correct
include asm subtree (especially for x86_64) so
am hesitant to do something that might break a build
for something I can''t test.

With the recent rapid churn in drivers and API,
we are having trouble keeping up with an out-of-tree
copy for Xenlinux/ia64, and would prefer to fix
the obvious x86-isms wherever possible rather than
continually (and manually) synching/patching.

If someone more experienced with the build
environment can add an "asm" link (such as
the one created by linux for include/asm),
I would be happy to provide a patch for the
actual changes.

The problem files (in sparse/include/asm-xen):

- synch_bitops.h: explicitly includes
  asm-i386/synch_bitops.h, should include
  <asm-xen/asm/synch_bitops.h>
- hypervisor.h: about half of this header is
  generic and half is x86-specific.  Should
  include <asm-xen/asm/hypervisor.h> for
  arch-dep code.

There are probably more (and certainly are in
driver directories)... this is just a start.

Thanks,
Dan

(P.S. If someone is kind enough to do this, please
respond to this message.)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

* Magenheimer, Dan (HP Labs Fort Collins) (dan.magenheimer@hp.com)
wrote:
> The problem files (in sparse/include/asm-xen):
I hit some of these as well.
> - synch_bitops.h: explicitly includes
>   asm-i386/synch_bitops.h, should include
>   <asm-xen/asm/synch_bitops.h>
I wondered about that.  Does that mean you have implementation of this,
or it it unnecessary on ia64?
> - hypervisor.h: about half of this header is
>   generic and half is x86-specific.  Should
>   include <asm-xen/asm/hypervisor.h> for
>   arch-dep code.
There''s already arch specific files (for hypercall), I wonder if they
could be reused?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 13 Sep 2005, at 00:25, Magenheimer, Dan (HP Labs Fort Collins) wrote:
> If someone more experienced with the build
> environment can add an "asm" link (such as
> the one created by linux for include/asm),
> I would be happy to provide a patch for the
> actual changes.
There''s already a symlink include/asm-xen/asm pointing to the 
appropriate arch-specific subdir under asm-xen. Or do you mean 
something else?
> The problem files (in sparse/include/asm-xen):
>
> - synch_bitops.h: explicitly includes
>   asm-i386/synch_bitops.h, should include
>   <asm-xen/asm/synch_bitops.h>
I can fix this one easily enough.
> - hypervisor.h: about half of this header is
>   generic and half is x86-specific.  Should
>   include <asm-xen/asm/hypervisor.h> for
>   arch-dep code.
Approximately none of it looks arch-independent. I''d be happy to move 
the whole lot to asm-xen/asm-i386 and link across to 
asm-xen/asm-x86_64. Unless you think more than a handful of lines could 
be kept as arch-independent code?

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

(Anybody else notice that gmane''s archive of xen-devel is
out-of-date?  I use digest mode for xen-devel so usually
use gmane for replies... trying nabble instead this time...)
>There''s already a symlink include/asm-xen/asm pointing to the 
>appropriate arch-specific subdir under asm-xen. Or do you mean 
>something else? 
Hmmm... It seemed like there should be but one didn''t appear
when I tried a build (on x86 or ia64).  I''ll look again.
>>    
>
>I can fix this one easily enough. 
OK, thanks!
>> - hypervisor.h: about half of this header is 
>Approximately none of it looks arch-independent. I''d be happy to
move
>the whole lot to asm-xen/asm-i386 and link across to 
>asm-xen/asm-x86_64. Unless you think more than a handful of lines could 
>be kept as arch-independent code? 
I thought at least the arch-independent function declarations
(which essentially define the API) should stay.  I agree this
is probably just a handful of lines.

thanks,
Dan

--
Sent from the Xen - Dev forum at Nabble.com:
http://www.nabble.com/Fix-blatant-non-archdep%27isms...-need-help-with-build-env-change--t302207.html#a849212


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>   
> wondered about that.  Does that mean you have implementation of this,
>or it it unnecessary on ia64?
I don''t think its necessary but I need to define the synch_xxx
functions to xxx.
>> - hypervisor.h: about half of this header is
>There''s already arch specific files (for hypercall), I wonder if
they
>could be reused?
There probably will be more, though I suppose it would be
possible to put all such arch-dep''isms into a single file.

Dan

--
Sent from the Xen - Dev forum at Nabble.com:
http://www.nabble.com/Fix-blatant-non-archdep%27isms...-need-help-with-build-env-change--t302207.html#a849242


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> > - hypervisor.h: about half of this header is
> >   generic and half is x86-specific.  Should
> >   include <asm-xen/asm/hypervisor.h> for
> >   arch-dep code.
> 
> Approximately none of it looks arch-independent. I''d be happy to
move
> the whole lot to asm-xen/asm-i386 and link across to 
> asm-xen/asm-x86_64. Unless you think more than a handful of 
> lines could 
> be kept as arch-independent code?
On closer look, I can only find one arch-independent line:
the declaration of xen_start_info.  So if you could move
the whole file to asm-xen/asm-i386, I can add the
asm-xen/asm-ia64 equivalent (the one declaration plus
some other stuff that could move to a more central file)
at the next xen-ia64-unstable pull.

Thanks,
Dan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel