This allows tools in the python directory to properly link to libxenstore.a on x86-64. --- tools/xenstore/Makefile.orig 2005-06-09 12:56:34.000000000 -0500 +++ tools/xenstore/Makefile 2005-06-09 13:48:06.000000000 -0500 @@ -20,6 +20,9 @@ BASECFLAGS+= -I. CFLAGS+=$(BASECFLAGS) +ifeq ($(XEN_TARGET_ARCH),x86_64) +CFLAGS += -fPIC +endif LDFLAGS=$(PROFILE) -L$(XEN_LIBXC) TESTDIR=`pwd`/testsuite/tmp TESTFLAGS=-DTESTING -- Jerone Young IBM Linux Technology Center jyoung5@us.ibm.com 512-838-1157 (T/L: 678-1157) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hollis Blanchard
2005-Jun-16 15:59 UTC
Re: [Xen-devel] [PATCH] more xenstore makefile fixes
On Thu, 2005-06-09 at 13:54 -0500, Jerone Young wrote:> This allows tools in the python directory to properly link to > libxenstore.a on x86-64. > --- tools/xenstore/Makefile.orig 2005-06-09 12:56:34.000000000 > -0500 > +++ tools/xenstore/Makefile 2005-06-09 13:48:06.000000000 -0500 > @@ -20,6 +20,9 @@ > BASECFLAGS+= -I. > > CFLAGS+=$(BASECFLAGS) > +ifeq ($(XEN_TARGET_ARCH),x86_64) > +CFLAGS += -fPIC > +endif > LDFLAGS=$(PROFILE) -L$(XEN_LIBXC) > TESTDIR=`pwd`/testsuite/tmp > TESTFLAGS=-DTESTINGPosition Independent Code (PIC) is needed for shared libraries on all architectures. This has come up before, on this list even: http://lists.xensource.com/archives/html/xen-devel/2005-02/msg00241.html I don''t expect xenstore would be very performance-critical... --- 1.4/tools/xenstore/Makefile 2005-06-10 03:42:25 -05:00 +++ edited/Makefile 2005-06-16 10:00:53 -05:00 @@ -20,9 +20,7 @@ BASECFLAGS+= -I. CFLAGS += $(BASECFLAGS) -ifeq ($(XEN_TARGET_ARCH),x86_64) CFLAGS += -fPIC -endif LDFLAGS=$(PROFILE) -L$(XEN_LIBXC) TESTDIR=`pwd`/testsuite/tmp TESTFLAGS=-DTESTING Signed-off-by: Hollis Blanchard -- Hollis Blanchard IBM Linux Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel