Ian Pratt
2005-May-11 15:33 UTC
RE: [Xen-devel] recent major -unstable changes cause ia64 build to bebroken
> Another new problem due to a common change... > > xen/include/xen/cpumask.h declares: > > extern cpumask_t cpu_online_map; > > However, with CONFIG_SMP off, xen/include/xen/smp.h defines > cpu_online_map to 1.It''s daft that we even have a CONFIG_SMP option in Xen. It spends most of its time broken because no-one using x86 builds it, and you won''t even be able to buy any non SMP hardware before long... I''d vote for expunging CONFIG_SMP. Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hollis Blanchard
2005-May-11 17:02 UTC
Re: [Xen-devel] recent major -unstable changes cause ia64 build to bebroken
On May 11, 2005, at 10:33 AM, Ian Pratt wrote:>> Another new problem due to a common change... >> >> xen/include/xen/cpumask.h declares: >> >> extern cpumask_t cpu_online_map; >> >> However, with CONFIG_SMP off, xen/include/xen/smp.h defines >> cpu_online_map to 1. > > It''s daft that we even have a CONFIG_SMP option in Xen. It spends most > of its time broken because no-one using x86 builds it, and you won''t > even be able to buy any non SMP hardware before long... > > I''d vote for expunging CONFIG_SMP.I''ve had this problem before too, and I wished that UP Xen would build, since so far I haven''t worried about SMP on PowerPC at all, and I think Dan is in the same situation. However, since nobody builds UP on x86 then it will continually be broken. I guess we could say goodbye to CONFIG_SMP and architectures without SMP support can just stub out the SMP functions, #define NR_CPUS 1, etc. This is what I''m doing now... Dan, does that work for you? -- Hollis Blanchard IBM Linux Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Maybe Matching Threads
- [PATCH] i386: introduce voyager smp_ops, fix voyager build
- [PATCH] i386: introduce voyager smp_ops, fix voyager build
- [PATCH] AMD, powernow: Update P-state directly when _PSD's CoordType is DOMAIN_COORD_TYPE_HW_ALL
- [PATCH 0 of 4] Prune outdated/impossible preprocessor symbols, and update VIOAPIC emulation
- [PATCH V2 1/2] cpufreq, xenpm: fix cpufreq and xenpm mismatch