Ian Pratt
2005-Apr-15 17:12 UTC
RE: [Xen-devel] notify_via_evtchn currently returning void (could be''int'')
> The function > include/asm-xen/evtchn.h:notify_via_evtchn(int) currently has > a ''void'' as return, however, there are useful error values > coming back from the Hypervisor call. Would it be possible to > have this value return an ''int'' and the result of the > Hypervisor call? Thanks.Yep, EINVAL is a possibility. Could you work up a patch? Thanks, Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Below is the patch that returns an ''int'' from the
notify_via_evtchn()
call.
Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
---
/xen/tmp/xeno-unstable.bk/linux-2.6.11-xen-sparse/include/asm-xen/evtchn.h
2005-03-31 16:17:04.000000000 -0500
+++ linux-2.6.11-xen-sparse/include/asm-xen/evtchn.h 2005-04-15
13:19:14.358768869 -0400
@@ -80,12 +80,12 @@
synch_clear_bit(port, &s->evtchn_pending[0]);
}
-static inline void notify_via_evtchn(int port)
+static inline int notify_via_evtchn(int port)
{
evtchn_op_t op;
op.cmd = EVTCHNOP_send;
op.u.send.local_port = port;
- (void)HYPERVISOR_event_channel_op(&op);
+ return HYPERVISOR_event_channel_op(&op);
}
/*
xen-devel-bounces@lists.xensource.com wrote on 04/15/2005 01:12:44 PM:
> > The function
> > include/asm-xen/evtchn.h:notify_via_evtchn(int) currently has
> > a ''void'' as return, however, there are useful error
values
> > coming back from the Hypervisor call. Would it be possible to
> > have this value return an ''int'' and the result of
the
> > Hypervisor call? Thanks.
>
> Yep, EINVAL is a possibility. Could you work up a patch?
>
> Thanks,
> Ian
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel