thr3ads.net - Xen devel - [Xen-devel] [PATCH] make mrproper remove include/.asm-ignore [Nov 2004]

If this information is useful, please help other people find it:
Share via:

Rik van Riel

2004-Nov-18 18:19 UTC

[Xen-devel] [PATCH] make mrproper remove include/.asm-ignore

When compiling multiple kernels in the same source tree, it is
normal to run ''make mrproper'' in-between builds.  This removes
include/asm, but it doesn''t remove include/.asm-ignore.

This leads to the main Makefile linking include/asm to the wrong
directory and the second kernel build failing.  This little patch
appears to fix that.


--- linux-2.6.9/Makefile.xenness	2004-11-18 11:53:26.000000000 -0500
+++ linux-2.6.9/Makefile	2004-11-18 11:53:54.000000000 -0500
@@ -921,7 +921,7 @@ CLEAN_FILES +=	vmlinux System.map \
  MRPROPER_DIRS  += include/config include2
  MRPROPER_FILES += .config .config.old include/asm .version \
                    include/linux/autoconf.h include/linux/version.h \
-                  Module.symvers tags TAGS cscope*
+                  Module.symvers tags TAGS cscope* include/.asm-ignore

  # clean - Delete most, but leave enough to build external modules
  #


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel

Ian Pratt

2004-Nov-18 20:03 UTC

head link

RE: [Xen-devel] [PATCH] make mrproper remove include/.asm-ignore

> When compiling multiple kernels in the same source tree, it 
> is normal to run ''make mrproper'' in-between builds.  This
> removes include/asm, but it doesn''t remove include/.asm-ignore.
> 
> This leads to the main Makefile linking include/asm to the 
> wrong directory and the second kernel build failing.  This 
> little patch appears to fix that.
Thanks for pointing this out. I guess a cleaner way of doing this would
be to have an ''archmrproper'' definition in our
arch/xen/Makefile.

Perhaps I should just make archmrproper dependent on archclean and we
should be OK.

Ian 
 > 
> --- linux-2.6.9/Makefile.xenness	2004-11-18 
> 11:53:26.000000000 -0500
> +++ linux-2.6.9/Makefile	2004-11-18 11:53:54.000000000 -0500
> @@ -921,7 +921,7 @@ CLEAN_FILES +=	vmlinux System.map \
>   MRPROPER_DIRS  += include/config include2
>   MRPROPER_FILES += .config .config.old include/asm .version \
>                     include/linux/autoconf.h include/linux/version.h \
> -                  Module.symvers tags TAGS cscope*
> +                  Module.symvers tags TAGS cscope* 
> include/.asm-ignore
> 
>   # clean - Delete most, but leave enough to build external modules
>   #
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: InterSystems CACHE FREE 
> OODBMS DOWNLOAD - A multidimensional database that combines 
> robust object and relational technologies, making it a 
> perfect match for Java, C++,COM, XML, ODBC and JDBC. 
> www.intersystems.com/match8 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/xen-devel
> 
> 

-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel

Ian Pratt

2004-Nov-19 09:16 UTC

head link

Re: [Xen-devel] [PATCH] make mrproper remove include/.asm-ignore

> > When compiling multiple kernels in the same source tree, it 
> > is normal to run ''make mrproper'' in-between builds. 
This
> > removes include/asm, but it doesn''t remove
include/.asm-ignore.
> > 
> > This leads to the main Makefile linking include/asm to the 
> > wrong directory and the second kernel build failing.  This 
> > little patch appears to fix that.
Hmm, I''ve looked at this a bit closer, and I''d like to clarify
why the patch is needed.

"make ARCH=xen mrproper" seems to delete everything OK.

Do you want it such that "make mrproper" (defaulting to i386)
cleans everything too? (seems reasonable).

I can apply the patch and include it in the changset we send
upstream.

Ian
  > > 
> > --- linux-2.6.9/Makefile.xenness	2004-11-18 
> > 11:53:26.000000000 -0500
> > +++ linux-2.6.9/Makefile	2004-11-18 11:53:54.000000000 -0500
> > @@ -921,7 +921,7 @@ CLEAN_FILES +=	vmlinux System.map \
> >   MRPROPER_DIRS  += include/config include2
> >   MRPROPER_FILES += .config .config.old include/asm .version \
> >                     include/linux/autoconf.h include/linux/version.h \
> > -                  Module.symvers tags TAGS cscope*
> > +                  Module.symvers tags TAGS cscope* 
> > include/.asm-ignore
> > 
> >   # clean - Delete most, but leave enough to build external modules
> >   #
> > 
> > 
> > -------------------------------------------------------
> > This SF.Net email is sponsored by: InterSystems CACHE FREE 
> > OODBMS DOWNLOAD - A multidimensional database that combines 
> > robust object and relational technologies, making it a 
> > perfect match for Java, C++,COM, XML, ODBC and JDBC. 
> > www.intersystems.com/match8 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/xen-devel
> > 
> > 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: InterSystems CACHE
> FREE OODBMS DOWNLOAD - A multidimensional database that combines
> robust object and relational technologies, making it a perfect match
> for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/xen-devel
 -=- MIME -=- > When compiling multiple kernels in the same source tree, it=20
> is normal to run ''make mrproper'' in-between builds. 
This=20
> removes include/asm, but it doesn''t remove include/.asm-ignore.
>=20
> This leads to the main Makefile linking include/asm to the=20
> wrong directory and the second kernel build failing.  This=20
> little patch appears to fix that.
Thanks for pointing this out. I guess a cleaner way of doing this would
be to have an ''archmrproper'' definition in our
arch/xen/Makefile.

Perhaps I should just make archmrproper dependent on archclean and we
should be OK.

Ian=20
=20>=20
> --- linux-2.6.9/Makefile.xenness	2004-11-18=20
> 11:53:26.000000000 -0500
> +++ linux-2.6.9/Makefile	2004-11-18 11:53:54.000000000 -0500
> @@ -921,7 +921,7 @@ CLEAN_FILES +=3D	vmlinux System.map \
>   MRPROPER_DIRS  +=3D include/config include2
>   MRPROPER_FILES +=3D .config .config.old include/asm .version \
>                     include/linux/autoconf.h include/linux/version.h \
> -                  Module.symvers tags TAGS cscope*
> +                  Module.symvers tags TAGS cscope*=20
> include/.asm-ignore
>=20
>   # clean - Delete most, but leave enough to build external modules
>   #
>=20
>=20
> -------------------------------------------------------
> This SF.Net email is sponsored by: InterSystems CACHE FREE=20
> OODBMS DOWNLOAD - A multidimensional database that combines=20
> robust object and relational technologies, making it a=20
> perfect match for Java, C++,COM, XML, ODBC and JDBC.=20
> www.intersystems.com/match8=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/xen-devel
>=20
>=20

-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel



-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel

Rik van Riel

2004-Nov-19 13:45 UTC

head link

Re: [Xen-devel] [PATCH] make mrproper remove include/.asm-ignore

On Fri, 19 Nov 2004, Ian Pratt wrote:
> "make ARCH=xen mrproper" seems to delete everything OK.
>
> Do you want it such that "make mrproper" (defaulting to i386)
> cleans everything too? (seems reasonable).
Absolutely.  When building kernel RPMs, I build i686, i686-smp,
i686-xen0 and i686-xenU kernels right after another, all from
the same source tree, with make "mrproper" inbetween builds.

It would seem reasonable that mrproper cleans up everything.
> I can apply the patch and include it in the changset we send
> upstream.
That would be useful to keep other kernel packagers from running
into the same (subtle) issue.

Rik
-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel

Xen devel - Nov 2004 - [PATCH] make mrproper remove include/.asm-ignore

[Xen-devel] [PATCH] make mrproper remove include/.asm-ignore

RE: [Xen-devel] [PATCH] make mrproper remove include/.asm-ignore

Re: [Xen-devel] [PATCH] make mrproper remove include/.asm-ignore

Re: [Xen-devel] [PATCH] make mrproper remove include/.asm-ignore