On Tue, Oct 04, 2016 at 10:37:49AM +1100, Bron Gondwana wrote:> Robert is in Australia visiting the FastMail office to co-work with us for a > couple of months, and I'd love to get this Xapian integration work done > during this time. We're also looking to release Cyrus IMAPd version 3.0 some > time in the next few months, and it would be great to not depend on too many > custom patches! Ideally I'd like to be running vanilla upstream Xapian > libraries on FastMail's production rather than keeping a separate branch as > well.Did you get a chance to look at the patch I linked to from the snippet PR? https://github.com/xapian/xapian/pull/117 Cheers, Olly
On Tue, 13 Dec 2016, at 15:04, Olly Betts wrote:> On Tue, Oct 04, 2016 at 10:37:49AM +1100, Bron Gondwana wrote: > > Robert is in Australia visiting the FastMail office to co-work with us for a > > couple of months, and I'd love to get this Xapian integration work done > > during this time. We're also looking to release Cyrus IMAPd version 3.0 some > > time in the next few months, and it would be great to not depend on too many > > custom patches! Ideally I'd like to be running vanilla upstream Xapian > > libraries on FastMail's production rather than keeping a separate branch as > > well. > > Did you get a chance to look at the patch I linked to from the snippet PR? > > https://github.com/xapian/xapian/pull/117I didn't. Robert is traveling at the moment, so I'm not sure if he's contactable. The latest code that Robert worked on before leaving is in our cyrusimap repo at: https://github.com/cyrusimap/xapian/commits/cyrus Bron. -- Bron Gondwana brong at fastmail.fm
I haven't had a chance to look at the patch and won't be able to do before January. Its design description sounds promising, though. The snippet generator code linked to by Bron contains mostly the same code as in my pull request, with two exceptions: it adds a flag to make the generator return the empty string for snippets without any matching terms. And it includes a fix to a possible memory corruption (only impacted our forked version). Cheers, Robert On Tue, Dec 13, 2016, at 15:14, Bron Gondwana wrote:> On Tue, 13 Dec 2016, at 15:04, Olly Betts wrote: > > On Tue, Oct 04, 2016 at 10:37:49AM +1100, Bron Gondwana wrote: > > > Robert is in Australia visiting the FastMail office to co-work with us for a > > > couple of months, and I'd love to get this Xapian integration work done > > > during this time. We're also looking to release Cyrus IMAPd version 3.0 some > > > time in the next few months, and it would be great to not depend on too many > > > custom patches! Ideally I'd like to be running vanilla upstream Xapian > > > libraries on FastMail's production rather than keeping a separate branch as > > > well. > > > > Did you get a chance to look at the patch I linked to from the snippet PR? > > > > https://github.com/xapian/xapian/pull/117 > > I didn't. Robert is traveling at the moment, so I'm not sure if he's > contactable. > > The latest code that Robert worked on before leaving is in our cyrusimap > repo at: > > https://github.com/cyrusimap/xapian/commits/cyrus > > Bron. > > -- > Bron Gondwana > brong at fastmail.fm