rakewx.rb: - Added a $debug_build variable so when we do eventually we can also release non debug builds. I did not make this a constant on purpose so in the package tasks we can change it to false if we want to always make non debug builds by default. - Changed wx_config to use the $debug_build variable rakemswin.rb: - Updated the copyright year. - removed the $DEBUG const and make use of $debug_build instead. rakemacosx.rb: - Updated the copyright year. - Removed $wx_version = "2.6.1" because it is set in use_wx_config above. - Removed commented out code, it has not been used in awhile and we can always look in CVS if we need it again. - Updated the framework task values to use 2.0 as the version instead of 0.5, can be changed again to whatever we go with. Also updated the copyright info. Sean _______________________________________________ wxruby-users mailing list wxruby-users@rubyforge.org http://rubyforge.org/mailman/listinfo/wxruby-users
These all looked reasonable to me, so I applied them. I trust other Mac and Windows users will let me (us) know if there were problems with those platforms. Thanks, Kevin On Mon, 2006-08-14 at 11:46 -0700, Sean Long wrote:> rakewx.rb: > - Added a $debug_build variable so when we do eventually we can also > release non debug builds. I did not make this a constant on purpose so > in the package tasks we can change it to false if we want to always > make non debug builds by default. > - Changed wx_config to use the $debug_build variable > > rakemswin.rb: > - Updated the copyright year. > - removed the $DEBUG const and make use of $debug_build instead. > > rakemacosx.rb: > - Updated the copyright year. > - Removed $wx_version = "2.6.1" because it is set in use_wx_config above. > - Removed commented out code, it has not been used in awhile and we > can always look in CVS if we need it again. > - Updated the framework task values to use 2.0 as the version instead > of 0.5, can be changed again to whatever we go with. Also updated the > copyright info. > > > Sean > _______________________________________________ > wxruby-users mailing list > wxruby-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/wxruby-users
Sean Long wrote:> rakewx.rb: > - Added a $debug_build variable so when we do eventually we can also > release non debug builds. I did not make this a constant on purpose so > in the package tasks we can change it to false if we want to always > make non debug builds by default. > - Changed wx_config to use the $debug_build variableCan I suggest the attached small patch? Without this, ''rake'' fails with a slew of non-obvious errors if the person compiling happens not to have built a debug build of wxwidgets. With this patch, developers (in the know) can request a debug build by doing rake DEBUG=1 But casual experimenters need not care about this setting - it will use their Wx configuration if they just do ''rake''. cheers alex -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: rakewx.patch Url: http://rubyforge.org/pipermail/wxruby-users/attachments/20060816/80f413a3/attachment.pl
On Wed, 2006-08-16 at 01:07 +0100, Alex Fenton wrote:> def wx_config(opt) > - debug_mode = ''--debug=no'' > - if $debug_build > - debug_mode = ''--debug=yes'' > - end > - > + debug_mode = ''--debug=yes'' if $debug_build > return `wx-config #{debug_mode} #{opt}`.strip + " " > endI know it''s ruby style, but I still look at the "x if y" structure as being a bug inherited from perl. My brain just doesn''t work that way. It''s like furniture instructions that say "Now cut the item in half. Oh, but before you do that, make sure you glued X to Y or the project will be ruined." Doh! So anyway, I would love it if you could revise the patch to use the old traditional if/x/end structure. Otherwise, looks good. Thanks, Kevin
> Can I suggest the attached small patch? Without this, ''rake'' fails with > a slew of non-obvious errors if the person compiling happens not to have > built a debug build of wxwidgets.Good catch, thanks. It would be a lot easier if wxMSW just had wx-config.> I know it''s ruby style, but I still look at the "x if y" structure as > being a bug inherited from perl. My brain just doesn''t work that way. > It''s like furniture instructions that say "Now cut the item in half. Oh, > but before you do that, make sure you glued X to Y or the project will > be ruined." Doh!That is a great analogy. As a long time c\c++ guy I am used to the if/x/end style. Sean
> I know it''s ruby style, but I still look at the "x if y" structure as > being a bug inherited from perl.hehe. that''s where I''ve picked up the habit.> My brain just doesn''t work that way. > It''s like furniture instructions that say "Now cut the item in half. Oh, > but before you do that, make sure you glued X to Y or the project will > be ruined." Doh! >LOL!> So anyway, I would love it if you could revise the patch to use the old > traditional if/x/end structure. >no probs. attached alex -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: rakewx.patch Url: http://rubyforge.org/pipermail/wxruby-users/attachments/20060816/1fe12f1f/attachment.pl