This patch fixes the following: - You can now use rake to build on Windows. - You can now use rake install to install the lib, no more extconf.rb needed! This should be cross platform, I took some code for installing from the Makefile that extconf.rb generated as a basis. I have tested it on OS X and will test tomorrow on Windows, I am 95% it will work cross platform. - I did get Windows compiling correctly with module named wxruby2 instead of wx. The problem was in extconf.rb so this fix is pretty useless now. I believe that is it, trying to make smaller patches for Kevin. Sean _______________________________________________ wxruby-users mailing list wxruby-users@rubyforge.org http://rubyforge.org/mailman/listinfo/wxruby-users
It does work fine on Windows. Sean On 8/1/05, Sean Long <sean.m.long@gmail.com> wrote:> This patch fixes the following: > > - You can now use rake to build on Windows. > - You can now use rake install to install the lib, no more extconf.rb > needed! This should be cross platform, I took some code for installing > from the Makefile that extconf.rb generated as a basis. I have tested > it on OS X and will test tomorrow on Windows, I am 95% it will work > cross platform. > - I did get Windows compiling correctly with module named wxruby2 > instead of wx. The problem was in extconf.rb so this fix is pretty > useless now. > > I believe that is it, trying to make smaller patches for Kevin. > > Sean > > >
Sean Long wrote:> This patch fixes the following: > > - You can now use rake to build on Windows. > - You can now use rake install to install the lib, no more extconf.rb > needed! This should be cross platform, I took some code for installing > from the Makefile that extconf.rb generated as a basis. I have tested > it on OS X and will test tomorrow on Windows, I am 95% it will work > cross platform. > - I did get Windows compiling correctly with module named wxruby2 > instead of wx. The problem was in extconf.rb so this fix is pretty > useless now. > > I believe that is it, trying to make smaller patches for Kevin.I appreciate your efforts to create smaller patches, but this still ended up being a HUGE patch, including a wide variety of changes to files in swig/classes and swig/classes/include. And, unfortunately, it includes some changes I don''t want to take, such as restoring the deprecated Sizer::Remove methods that I had removed. So I really don''t want to apply the whole patch because safely backing out the stuff I don''t want is going to be difficult. As I said before, I really haven''t worked much with patches, either as a creator (contributor) or receiver (maintainer). So I''m not sure what to suggest. I just know that if a patch contains more than a couple files, it is probably trying to do to much and should be split up. Can you submit one diff for extconf.rb, and a second that only includes rakefile and the rake/ directory? Each of the .i or wx*.h files that you want to change should be its own diff. If that''s too painful for you, let''s try to find some other approach. This is one of the main reasons that I want to (eventually) move away from CVS and start using a distributed SCM tool. Each contributor should have full SCM capabilities, and we should be able to pull patches from each other. Thanks (and sorry to be a pain about this), Kevin
The patch was strange because my local working copy got corrupted and I had to checkout a fresh copy and move over the changes. Here is a patch that only has the changes to rake for install and getting compiling working on Windows. I am not going to send a patch for the extconf.rb since the rake changes render it obsolete. Sean On 8/2/05, Kevin Smith <wxruby@qualitycode.com> wrote:> Sean Long wrote: > > This patch fixes the following: > > > > - You can now use rake to build on Windows. > > - You can now use rake install to install the lib, no more extconf.rb > > needed! This should be cross platform, I took some code for installing > > from the Makefile that extconf.rb generated as a basis. I have tested > > it on OS X and will test tomorrow on Windows, I am 95% it will work > > cross platform. > > - I did get Windows compiling correctly with module named wxruby2 > > instead of wx. The problem was in extconf.rb so this fix is pretty > > useless now. > > > > I believe that is it, trying to make smaller patches for Kevin. > > I appreciate your efforts to create smaller patches, but this still > ended up being a HUGE patch, including a wide variety of changes to > files in swig/classes and swig/classes/include. And, unfortunately, it > includes some changes I don''t want to take, such as restoring the > deprecated Sizer::Remove methods that I had removed. So I really don''t > want to apply the whole patch because safely backing out the stuff I > don''t want is going to be difficult. > > As I said before, I really haven''t worked much with patches, either as a > creator (contributor) or receiver (maintainer). So I''m not sure what to > suggest. I just know that if a patch contains more than a couple files, > it is probably trying to do to much and should be split up. > > Can you submit one diff for extconf.rb, and a second that only includes > rakefile and the rake/ directory? Each of the .i or wx*.h files that you > want to change should be its own diff. If that''s too painful for you, > let''s try to find some other approach. > > This is one of the main reasons that I want to (eventually) move away > from CVS and start using a distributed SCM tool. Each contributor should > have full SCM capabilities, and we should be able to pull patches from > each other. > > Thanks (and sorry to be a pain about this), > > Kevin > > >-------------- next part -------------- A non-text attachment was scrubbed... Name: wxRuby2_rake_install.patch Type: application/octet-stream Size: 4236 bytes Desc: not available Url : http://rubyforge.org/pipermail/wxruby-users/attachments/20050802/81209ffd/wxRuby2_rake_install-0001.obj
Sean Long wrote:> The patch was strange because my local working copy got corrupted and > I had to checkout a fresh copy and move over the changes.Ah.> Here is a patch that only has the changes to rake for install and getting > compiling working on Windows. I am not going to send a patch for the > extconf.rb since the rake changes render it obsolete.Ok. That installed cleanly. I then refactored it a bit, and fixed a problem when the target install directory didn''t already exist. I have officially deprecated extconf.rb, and plan to remove it from the project after about a week, unless someone raises an objection. Thanks! Kevin
The new rake file seems to be working OK. I had to compile several libraries that aren''t actually needed by the project (yet). Specifically: wxbase26[d]_net.lib [deprecated for Ruby net functions?] wxbase26[d]_odbc.lib wxmsw26[d]_dbgrid.lib wxmsw26d_media.lib wxregexd.lib [deprecated for Ruby regex functions?] Roy Kevin Smith wrote:> Sean Long wrote: > >> The patch was strange because my local working copy got corrupted and >> I had to checkout a fresh copy and move over the changes. > > > Ah. > >> Here is a patch that only has the changes to rake for install and >> getting >> compiling working on Windows. I am not going to send a patch for the >> extconf.rb since the rake changes render it obsolete. > > > Ok. That installed cleanly. I then refactored it a bit, and fixed a > problem when the target install directory didn''t already exist. > > I have officially deprecated extconf.rb, and plan to remove it from > the project after about a week, unless someone raises an objection. > > Thanks! > > Kevin > _______________________________________________ > wxruby-users mailing list > wxruby-users@rubyforge.org > http://rubyforge.org/mailman/listinfo/wxruby-users > > >
Hi Roy, Is this still an issue? Is it something that we need to describe in the README requirements section? Thanks, Kevin Roy Sutton wrote:> The new rake file seems to be working OK. I had to compile several > libraries that aren''t actually needed by the project (yet). > > Specifically: > > wxbase26[d]_net.lib [deprecated for Ruby net functions?] > wxbase26[d]_odbc.lib > wxmsw26[d]_dbgrid.lib > wxmsw26d_media.lib > wxregexd.lib [deprecated for Ruby regex functions?] > > Roy
This isn''t an issue per se. I was just noting that all wxWindows libraries must be compiled for the new rakefile to work. I was only building as needed before. I don''t think it''s too much to expect people to build all needed wxWindows libraries, especially as they will probably be needed later (with the possible exception of the net and regexp libraries). Although this does bring up a question: Is debug the default build for wxRuby? Or only now before release? Will future version link against non-debug by default? Or should current version be linking against non-debug and are only linking against debug on Windows because of a bug? I do wish there were a simpler way to build them all on windows (There might be!). But that''s really a wxWindows issue, not a wxRuby issue. Roy Kevin Smith wrote:> Hi Roy, > > Is this still an issue? Is it something that we need to describe in > the README requirements section? > > Thanks, > > Kevin > > > Roy Sutton wrote: > >> The new rake file seems to be working OK. I had to compile several >> libraries that aren''t actually needed by the project (yet). >> >> Specifically: >> >> wxbase26[d]_net.lib [deprecated for Ruby net functions?] >> wxbase26[d]_odbc.lib >> wxmsw26[d]_dbgrid.lib >> wxmsw26d_media.lib >> wxregexd.lib [deprecated for Ruby regex functions?] >> >> Roy > > _______________________________________________ > wxruby-users mailing list > wxruby-users@rubyforge.org > http://rubyforge.org/mailman/listinfo/wxruby-users > > >
Roy Sutton wrote:> Although this does bring up a question: Is debug the default build for > wxRuby? Or only now before release? Will future version link against > non-debug by default? Or should current version be linking against > non-debug and are only linking against debug on Windows because of a bug?As soon as wxruby2 is more stable, we should default to non-DEBUG building. There should be a simple rakefile setting to choose DEBUG or not. I think it is already there, but I haven''t looked or tried it recently. For now, especially with the memory problems, it is helpful to have as many people as possible running the debug version. Kevin