nobody at rubyforge.org
2007-Jun-23 18:00 UTC
[Wxruby-development] [1064] trunk/wxruby2/swig/Events.i: Removed unused func, updated comments
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type"
content="text/html; charset=utf-8" /><style
type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:'':'';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family:
verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;
font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding:
6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid;
padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family:
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch
.binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[1064] trunk/wxruby2/swig/Events.i: Removed unused func, updated
comments</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd>1064</dd>
<dt>Author</dt> <dd>brokentoy</dd>
<dt>Date</dt> <dd>2007-06-23 14:00:42 -0400 (Sat, 23 Jun
2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>Removed unused func, updated comments</pre>
<h3>Modified Paths</h3>
<ul>
<li><a
href="#trunkwxruby2swigEventsi">trunk/wxruby2/swig/Events.i</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwxruby2swigEventsi"></a>
<div class="modfile"><h4>Modified:
trunk/wxruby2/swig/Events.i (1063 => 1064)</h4>
<pre class="diff"><span>
<span class="info">---
trunk/wxruby2/swig/Events.i        2007-06-23
18:00:12 UTC (rev 1063)
+++
trunk/wxruby2/swig/Events.i        2007-06-23
18:00:42 UTC (rev 1064)
</span><span class="lines">@@ -1,3 +1,4 @@
</span><ins>+
</ins><span class="cx"> // Copyright 2004-2007 by Kevin
Smith
</span><span class="cx"> // released under the MIT-style
wxruby2 license
</span><span class="cx"> %include "common.i"
</span><span class="lines">@@ -311,20 +312,18 @@
</span><span class="cx"> %constant const int
wxEVT_COMMAND_AUINOTEBOOK_DRAG_MOTION;
</span><span class="cx"> %constant const int
wxEVT_COMMAND_AUINOTEBOOK_ALLOW_DND;
</span><span class="cx">
</span><del>-#############################################################################
-#### NOTE: Before adding anything below this line, consider whether it really
-#### belongs in swig/classes/include/events.rb instead!!!
-#############################################################################
</del><span class="cx">
</span><del>-
-
</del><span class="cx"> %{
</span><ins>+
+// TODO - there is considerable duplication between the public ruby
+// ''connect'' method and internal_connect - in fact all the
evt_xxx
+// methods could now be implemented in ruby via ''connect''
+// Internal method that links a ruby Proc (the block passed to evt_xxx)
+// to the WxWidgets C++ event handler method.
</ins><span class="cx"> extern swig_class cWxEvtHandler;
</span><ins>+extern void internal_connect(VALUE self, int firstId,
int lastId,
+                                                        
wxEventType eventType);
</ins><span class="cx">
</span><del>-void internal_connect(VALUE self, int firstId, int
lastId,
- wxEventType eventType);
-
-
</del><span class="cx"> static VALUE
internal_evt_with_id(int argc, VALUE *argv, VALUE self,
</span><span class="cx"> wxEventType eventType)
</span><span class="cx"> {
</span><span class="lines">@@ -359,17 +358,4 @@
</span><span class="cx"> return Qnil;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static VALUE connect_fnc(int argc, VALUE *argv, VALUE
self)
-{
- if (argc != 3)
- rb_raise(rb_eArgError, "wrong # of arguments(%d for 3)",
argc);
-
- int id = NUM2INT(argv[0]);
- int lastId = NUM2INT(argv[1]);
- int type = NUM2INT(argv[2]);
-
- internal_connect(self, id, lastId, type);
- return Qnil;
-}
-
</del><span class="cx"> %}
</span></span></pre>
</div>
</div>
</body>
</html>
Possibly Parallel Threads
- [1063] trunk/wxruby2/swig/classes/EvtHandler.i: Add a public ''connect'' method for handling arbitary user-defined events
- [1066] trunk/wxruby2/swig: Move EVT constants in swig/classes/Event.i; add a few missing ones
- [1035] trunk/wxruby2/swig/classes/EvtHandler.i: Removed a heap of redundant stuff that''s been #if 0''d for a while
- [1039] trunk/wxruby2/swig/Events.i: Remove some debugging output
- [723] trunk/wxruby2: Added WindowCreateEvent and WindowDestroyEvent + event handlers (AF)
Wisdom of the Ancients
