thr3ads.net - wxruby development - [Wxruby-development] [876] trunk/wxruby2/samples/printing/printing.rb: Fix a crasher if scale = 0; fix variable rename [Mar 2007]

If this information is useful, please help other people find it:
Share via:

nobody at rubyforge.org

2007-Mar-06 19:17 UTC

[Wxruby-development] [876] trunk/wxruby2/samples/printing/printing.rb: Fix a crasher if scale = 0; fix variable rename

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type"
content="text/html; charset=utf-8" /><style
type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:'':'';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family:
verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;
font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding:
6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid;
padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family:
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch
.binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[876] trunk/wxruby2/samples/printing/printing.rb: Fix a crasher if
scale = 0; fix variable rename</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd>876</dd>
<dt>Author</dt> <dd>brokentoy</dd>
<dt>Date</dt> <dd>2007-03-06 14:17:41 -0500 (Tue, 06 Mar
2007)</dd>
</dl>

<h3>Log Message</h3>
<pre>Fix a crasher if scale = 0; fix variable rename</pre>

<h3>Modified Paths</h3>
<ul>
<li><a
href="#trunkwxruby2samplesprintingprintingrb">trunk/wxruby2/samples/printing/printing.rb</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwxruby2samplesprintingprintingrb"></a>
<div class="modfile"><h4>Modified:
trunk/wxruby2/samples/printing/printing.rb (875 => 876)</h4>
<pre class="diff"><span>
<span class="info">---
trunk/wxruby2/samples/printing/printing.rb&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp2007-02-14
20:07:21 UTC (rev 875)
+++
trunk/wxruby2/samples/printing/printing.rb&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp2007-03-06
19:17:41 UTC (rev 876)
</span><span class="lines">@@ -301,14 +301,13 @@
</span><span class="cx">     # but in fact is too small
for some reason. This is a detail that will
</span><span class="cx">     # need to be addressed at
some point but can be fudged for the
</span><span class="cx">     # moment.
</span><del>-    scale = (ppi_printer_x/ppi_screen_x)
</del><ins>+    scale = ( ppi_printer_x.to_f / ppi_screen_x.to_f )
</ins><span class="cx"> 
</span><span class="cx">     # Now we have to check in
case our real page size is reduced
</span><span class="cx">     # (e.g. because
we''re drawing to a print preview memory DC)
</span><span class="cx">     page_width, page_height =
get_page_size_pixels
</span><span class="cx">     w, h = dc.get_size
</span><span class="cx">     
</span><del>-
</del><span class="cx">     # If printer pageWidth ==
current DC width, then this doesn''t
</span><span class="cx">     # change. But w might be the
preview bitmap width, so scale down.
</span><span class="cx">     overall_scale = scale *
(w/page_width)
</span><span class="lines">@@ -391,8 +390,8 @@
</span><span class="cx">     dc.draw_text(text,
x_pos.to_i, top_margin_logical)
</span><span class="cx"> 
</span><span class="cx">     dc.set_pen(Wx::BLACK_PEN)
</span><del>-    dc.draw_line( left_margin_logical,
(top_margin_logical+y_extent).to_i,
-                  right_margin_logical, (top_margin_logical+yExtent).to_i )
</del><ins>+    dc.draw_line( left_margin_logical,
(top_margin_logical + y_extent).to_i,
+                  right_margin_logical, (top_margin_logical + y_extent).to_i )
</ins><span class="cx"> 
</span><span class="cx">     return true
</span><span class="cx">   end  
</span></span></pre>
</div>
</div>

</body>
</html>

Possibly Parallel Threads

Search for more possibly parallel threads

wxruby development - Mar 2007 - [876] trunk/wxruby2/samples/printing/printing.rb: Fix a crasher if scale = 0; fix variable rename

[Wxruby-development] [876] trunk/wxruby2/samples/printing/printing.rb: Fix a crasher if scale = 0; fix variable rename

Possibly Parallel Threads

Wisdom of the Ancients