wine users - Aug 2009 - Timezone not recognised kludge

This is for Wine 1.1.28 compiled under a customised personal Linux based on
Slackware.

When running winefile from a terminal, get a line:

"fixme:ntdll:find_reg_tz_info Can't find matching timezone information
in the registry for bias -720, std (d/m/y): 5/04/2009, dlt (d/m/y):
27/09/2009"

Wine source: ../dlls/ntdll/time.c holds the function
"find_reg_tz_info".

Running: # WINEDEBUG=trace+ntdll wine winefile

gives a dump of the trace statements for this function and shows the registry
timezone information for timezones as it scans each. It cannot find a match.

This I kind of expect as the TZ info for NZ has been altered recently so the
wine source ../tools/wine.inf.in is incorrect.

To do a quick fix I edited the registry timezone info for NZ and changed the
day, month and hour to conform to the new values.

However this still did not work!.

Only when I changed the year to 2009 did it work ok.

I think this is basically a bug in the ntdll, time.c functions as the year
should not figure in the calculations?.

A resulting reg file fix follows, with comments attached:

[quote]
REGEDIT4

[HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT/CurrentVersion\Time Zones\New
Zealand Standard Time]
"Display"="Pacific/Auckland"
"Dlt"="New Zealand Daylight Time"
"Std"="New Zealand Standard Time"
"TZI"=hex:30,fd,ff,ff,\
          00,00,00,00,\
	  c4,ff,ff,ff,\
          d9,07,04,00,00,00,05,00,02,00,00,00,00,00,00,00,\
	  d9,07,09,00,00,00,1b,00,02,00,00,00,00,00,00,00
; FFFFFD30 = -720 (LONG Bias)
; 00000000 = 0    (LONG StandardBias)
; ffffffc4 = -60  (LONG DaylightBias)
; 2009-04-05 2:00 (RTL_SYSTEM_TIME StandardDate)
; 2009-09-27 2:00 (RTL_SYSTEM_TIME DaylightDate)

On Tue, Aug 25, 2009 at 5:35 PM, llewro<wineforum-user at winehq.org>
wrote:
> This is for Wine 1.1.28 compiled under a customised personal Linux based on
Slackware.
>
> When running winefile from a terminal, get a line:
>
> "fixme:ntdll:find_reg_tz_info Can't find matching timezone
information in the registry for bias -720, std (d/m/y): 5/04/2009, dlt (d/m/y):
27/09/2009"
>
> Wine source: ../dlls/ntdll/time.c holds the function
"find_reg_tz_info".
>
> Running: # WINEDEBUG=trace+ntdll wine winefile
>
> gives a dump of the trace statements for this function and shows the
registry timezone information for timezones as it scans each. It cannot find a
match.
>
> This I kind of expect as the TZ info for NZ has been altered recently so
the wine source ../tools/wine.inf.in is incorrect.
>
> To do a quick fix I edited the registry timezone info for NZ and changed
the day, month and hour to conform to the new values.
>
> However this still did not work!.
>
> Only when I changed the year to 2009 did it work ok.
>
> I think this is basically a bug in the ntdll, time.c functions as the year
should not figure in the calculations?.
>
> A resulting reg file fix follows, with comments attached:
>
> [quote]
> REGEDIT4
>
> [HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT/CurrentVersion\Time
Zones\New Zealand Standard Time]
> "Display"="Pacific/Auckland"
> "Dlt"="New Zealand Daylight Time"
> "Std"="New Zealand Standard Time"
> "TZI"=hex:30,fd,ff,ff,\
> ? ? ? ? ?00,00,00,00,\
> ? ? ? ? ?c4,ff,ff,ff,\
> ? ? ? ? ?d9,07,04,00,00,00,05,00,02,00,00,00,00,00,00,00,\
> ? ? ? ? ?d9,07,09,00,00,00,1b,00,02,00,00,00,00,00,00,00
> ; FFFFFD30 = -720 (LONG Bias)
> ; 00000000 = 0 ? ?(LONG StandardBias)
> ; ffffffc4 = -60 ?(LONG DaylightBias)
> ; 2009-04-05 2:00 (RTL_SYSTEM_TIME StandardDate)
> ; 2009-09-27 2:00 (RTL_SYSTEM_TIME DaylightDate)
A patch to wine.inf.in is the proper thing to do, e.g.,:
diff --git a/tools/wine.inf.in b/tools/wine.inf.in
index 8be3246..f3649dd 100644
--- a/tools/wine.inf.in
+++ b/tools/wine.inf.in
@@ -2789,7 +2789,7 @@ HKLM,%CurrentVersionNT%\Time Zones\Nepal
Standard Time,"TZI",1,a7,fe,ff,ff,00,00
 HKLM,%CurrentVersionNT%\Time Zones\New Zealand Standard
Time,"Display",,"Pacific/Auckland"
 HKLM,%CurrentVersionNT%\Time Zones\New Zealand Standard
Time,"Dlt",,"New Zealand Daylight Time"
 HKLM,%CurrentVersionNT%\Time Zones\New Zealand Standard
Time,"Std",,"New Zealand Standard Time"
-HKLM,%CurrentVersionNT%\Time Zones\New Zealand Standard
Time,"TZI",1,30,fd,ff,ff,00,00,00,00,c4,ff,ff,ff,00,00,04,00,00,00,01,00,03,00,00,00,00,00,00,00,00,00,09,00,00,00,05,00,02,00,00,00,00,00,00,00
+HKLM,%CurrentVersionNT%\Time Zones\New Zealand Standard
Time,"TZI",1,30,fd,ff,ff,00,00,00,00,c4,ff,ff,ff,d9,07,04,00,00,00,05,00,02,00,00,00,00,00,00,00,d9,07,09,00,00,00,1b,00,02,00,00,00,00,00,00,00
 HKLM,%CurrentVersionNT%\Time Zones\Newfoundland Standard
Time,"Display",,"America/St_Johns"
 HKLM,%CurrentVersionNT%\Time Zones\Newfoundland Standard
Time,"Dlt",,"Newfoundland Daylight Time"
 HKLM,%CurrentVersionNT%\Time Zones\Newfoundland Standard
Time,"Std",,"Newfoundland Standard Time"

-- 
-Austin

[This email is either empty or too large to be displayed at this time]

Austin

Gotcha about the wine.inf however using 2009 will only work
for this year!. 

The trace dump mentioned in my original post had all years in
all timezones, return 0000. I assume this is so they work for
any year.

The fault seems to be in the comparison of the system derived
timezone with that in the registry, in the function mentioned
above.

Cheers