Vorbis dev - Mar 2009 - Add vorbis_dsp_init() ?

Hi,

This mozilla bug report is a crash triggered by a Vorbis file with
corrupt headers:

https://bugzilla.mozilla.org/show_bug.cgi?id=481601

The patch to fix the crash adds a new vorbis_dsp_init() function to
libvorbis, and calls
that from fs_vorbis_init() in libfishsound:

https://bug481601.bugzilla.mozilla.org/attachment.cgi?id=366150

The public function it adds is:

void vorbis_dsp_init(vorbis_dsp_state *v){
  memset(v,0,sizeof(*v));
}

Is it ok to commit the libvorbis patch to svn.xiph.org/trunk/vorbis?

Conrad.

Conrad Parker wrote:
> This mozilla bug report is a crash triggered by a Vorbis file with
> corrupt headers:
> https://bugzilla.mozilla.org/show_bug.cgi?id=481601
???

So how come lib/block.c in vorbis svn gets renamed to
lib/vorbis_block.c?
> The patch to fix the crash adds a new vorbis_dsp_init() function to
> libvorbis, and calls
Since the vorbis_dsp_state stuct is defined in a public header
file, why do you need to add a function to libvorbis? The memset
could just  as easily  and correctly be done in fishsound.

Erik
-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"Always code as if the person who ends up maintaining your
code will be a violent psychopath who knows where you live."
-- Martin Golding