Vorbis dev - Oct 2008 - Attn Ivo. Re patches 15347 and 15376

Ivo,

Your patch number 16347 uses _fseeki64 when _WIN32 is defined.

Unfortunately, MinGW (or at least the Linux -> Win32 cross compiler
I'm using) defines _WIN32 but isn't aware of _fseeki64.

I have therefore modified your solution a little and commited it
as rev 15376. The code now looks like this:

    #ifdef __MINGW32__
      return fseeko64(f,off,whence);
    #elif defined (_WIN32)
      return _fseeki64(f,off,whence);
    #else
      return fseek(f,off,whence);
    #endif

which should work for MinGW and the windows compilers.

However, since I don't have access to windows, can you please check
and confirm that this hasn't broken anything?

Cheers,
Erik
-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"Don't hate the media. Become the media."
- Jello Biafra

On 10/5/08, Erik de Castro Lopo <mle+la at mega-nerd.com>
wrote:
> Unfortunately, MinGW (or at least the Linux -> Win32 cross compiler
> I'm using) defines _WIN32 but isn't aware of _fseeki64.
(..)
> However, since I don't have access to windows, can you please check
> and confirm that this hasn't broken anything?
I don't have Windows to confirm either, but I doubt it breaks anything
to chain both Win32 and Mingw32 with different functions.  They end up
achieving the same thing.

-Ivo

Peter Harris wrote:
> Bare ov_open should not be used on Win32. So _fseek64_wrap in
> vorbisfile.c will never be called. Therefore, no change is necessary.
Oh... It was just as you say.
Thank you for a reply.

Aoyumi