Hi! While implementing a Vorbis I decoder, I have found a few errors in the specification. After making the following changes everything works as advertised, thank you! Errata: 1.) In section 7.2.2 Floor1 header decode (on a side not wouldn't 7.2.2.1 be the logical number here, looking at the overall structure of the document?), step 21 element element ([j] + [floor1_values]) should insted be element [floor1_values] 2.) In section 7.2.2.2.1, step 15 [room] is mispelled as [root] 3.) In section 7.2.2.2.2, step 5 [floor1_step2_flag]' should instead be [floor1_step2_flag]' element [i] 4.) In section 8.6.2, after step 3 there is a step missing or it should be part of step 3: [partition_count] =0 ; iterate while [partition_count] is less then [ptns_to_read] With these changes my decoder is apparently ogg vorbis compliant AND decodes my vorbis streams! thanks, bye Denes -- - Use the Source Luke ! -
Hi! To answer my email, most of these issues don't exist in the "chapterized" html specification, but they do appear in the "one html page" specification. The errors that can also be found in the "chapterized" specification:> 2.) > In section 7.2.2.2.1, step 15 [room] is mispelled as [root] > > 3.) > In section 7.2.2.2.2, step 5 [floor1_step2_flag]' should instead be > [floor1_step2_flag]' element [i] >Nuances I must admit. However imho the different forms of the specifications should perhaps be synchronized (in case someone reads one of them - but we don't know which). thanks, bye Denes -- - Use the Source Luke ! -
> While implementing a Vorbis I decoder, I have found a few errors in the > specification. After making the following changes everything works as > advertised, thank you! > > Errata: > 1.) > In section 7.2.2 Floor1 header decode (on a side not wouldn't 7.2.2.1 be the > logical number here, looking at the overall structure of the document?), > step 21 element element ([j] + [floor1_values]) should insted be > element [floor1_values] > > 2.) > In section 7.2.2.2.1, step 15 [room] is mispelled as [root] > > 3.) > In section 7.2.2.2.2, step 5 [floor1_step2_flag]' should instead be > [floor1_step2_flag]' element [i] > > 4.) > In section 8.6.2, after step 3 there is a step missing or it should be part of > step 3: [partition_count] =0 ; iterate while [partition_count] is less then > [ptns_to_read]I've checked against the spec and you are correct on all points. I'll get this additional proofreading in place, and thatnks for taking the time to send along the fixes. Correct fixes are always appreciated! Monty