Jeff Squyres
2001-Aug-19 13:04 UTC
[vorbis-dev] C++ style comment in vorbis-tools/oggenc/utf.8
vorbis-tools/oggenc/utf8.c:164 has a //-style comment; it should be /* ...
*/ so that non-gcc compilers won't barf (e.g., solaris Forte 6.1 cc).
Patch included, if you're really lazy. :-)
{+} Jeff Squyres
{+} squyres@cse.nd.edu
{+} Perpetual Obsessive Notre Dame Student Craving Utter Madness
{+} "I came to ND for 4 years and ended up staying for a decade"
Index: oggenc/utf8.c
==================================================================RCS file:
/usr/local/cvsroot/vorbis-tools/oggenc/utf8.c,v
retrieving revision 1.7
diff -c -r1.7 utf8.c
*** oggenc/utf8.c 2001/08/14 12:55:51 1.7
--- oggenc/utf8.c 2001/08/19 19:03:37
***************
*** 161,167 ****
*/
int simple_utf8_encode(const char *from, char **to, const char *encoding)
{
! // can you always know this will be 16 bit?
unsigned short *unicode;
charset_map *map;
int index = 0;
--- 161,167 ----
*/
int simple_utf8_encode(const char *from, char **to, const char *encoding)
{
! /* can you always know this will be 16 bit? */
unsigned short *unicode;
charset_map *map;
int index = 0;
--- >8 ----
List archives: http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body. No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.
On Sunday, August 19, 2001, at 03:04 , Jeff Squyres wrote:> vorbis-tools/oggenc/utf8.c:164 has a //-style comment; it should > be /* ... > */ so that non-gcc compilers won't barf (e.g., solaris Forte 6.1 cc).Thanks for the catch, it's fixed now. -r --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.