Vorbis dev - Jul 2001 - Patch for bitrate information in ogginfo

With this patch, ogginfo will display bitrate information
(upper/lower/nominal/average bitrate).
It is patched against today's CVS code (main branch).

I am also working on true VBR support in oggenc (the user
can specify the minimum & maximum bitrate) and will send
a patch when it's done.

<HR NOSHADE>
<UL>
<LI>application/x-gzip attachment: ogginfo-diff.gz
</UL>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ogginfo-diff.gz
Type: application/octet-stream
Size: 325 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20010728/17aaa539/ogginfo-diff-0001.obj

On 2001.07.28 17:31:20 +0200 Hongli Lai wrote:
> With this patch, ogginfo will display bitrate information
> (upper/lower/nominal/average bitrate).
> It is patched against today's CVS code (main branch).
Could you guys at least take a look at my patch?
I hate being ignore when I contribute code.

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

On Sat, 28 Jul 2001, Hongli Lai wrote:
> With this patch, ogginfo will display bitrate information
> (upper/lower/nominal/average bitrate).
> It is patched against today's CVS code (main branch).
> 
> I am also working on true VBR support in oggenc (the user
> can specify the minimum & maximum bitrate) and will send
> a patch when it's done.
[I'm taking a break from reading.]

The patch looks fine.  Before I apply it, I need to get some clarification
from those who know more about the Vorbis format:

The docs for vorbis_info (vorbis/doc/vorbisfile/vorbis_info.html) say that
both bitrate_upper and bitrate_lower can be *unset* if no upper or lower limit
exists.  Does a value of -1 mean "unset"?  This is the value I am
getting from
the test files I used.

If so, I'm going to modify the patch to say "bitrate_upper=none"
and
"bitrate_lower=none" if these values are set to -1.  Hopefully, this
will
prevent confusion.

[For future reference on patches: As has been pointed out, diff -u is easier
to read.  Also, I prefer that small patches are not compressed so that I can
quickly review them within my email program.]

Thanks for the patch!  I'll commit it once I get some clarification (no
later
than tomorrow).


---
Stan Seibert

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

On Sat, 28 Jul 2001, Hongli Lai wrote:
> With this patch, ogginfo will display bitrate information
> (upper/lower/nominal/average bitrate).
> It is patched against today's CVS code (main branch).
I have committed a modified version of this patch to CVS and updated the
manpage.


---
Stan Seibert

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.