Virtualization - Feb 2023 - [PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank

On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann
wrote:
> Set the VGA bit for unblanking with macro constants instead of magic
> values. No functional changes.
blank/unblank should work simliar to bochs (see commit 250e743915d4),
that is maybe a nice thing to add of you modernize the driver anyway.

take care,
  Gerd

Hi,

thanks for taking a look at the patches.

Am 16.02.23 um 12:33 schrieb Gerd Hoffmann:
> On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann wrote:
>> Set the VGA bit for unblanking with macro constants instead of magic
>> values. No functional changes.
> 
> blank/unblank should work simliar to bochs (see commit 250e743915d4),
> that is maybe a nice thing to add of you modernize the driver anyway.
Yeah, it's the VGA PAS field. [1] But is it really called blanking? PAS 
controls palette access, but blanking is sounds more like DPMS.

The PAS setting is actually part of the primary plane, so it's current 
location in the CRTC code is misleading. I didn't want to change the 
driver logic too much, but I guess I'll fix that in the next iteration.

Best regards
Thomas

[1] 
https://web.stanford.edu/class/cs140/projects/pintos/specs/freevga/vga/attrreg.htm#3C0
> 
> take care,
>    Gerd
> 
-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 N?rnberg, Germany
(HRB 36809, AG N?rnberg)
Gesch?ftsf?hrer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20230216/97e2e345/attachment.sig>

Hi

Am 16.02.23 um 12:33 schrieb Gerd Hoffmann:
> On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann wrote:
>> Set the VGA bit for unblanking with macro constants instead of magic
>> values. No functional changes.
> 
> blank/unblank should work simliar to bochs (see commit 250e743915d4),
> that is maybe a nice thing to add of you modernize the driver anyway.
> 
> take care,
>    Gerd
> 
Do you have comments on the other patches?

Best regards
Thomas

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 N?rnberg, Germany
(HRB 36809, AG N?rnberg)
Gesch?ftsf?hrer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20230220/9f77a8f4/attachment.sig>