Virtualization - Jul 2021 - [PATCH v13] i2c: virtio: add a virtio i2c frontend driver

On 05-07-21, 11:45, Andy Shevchenko wrote:
> On Mon, Jul 5, 2021 at 11:03 AM Viresh Kumar <viresh.kumar at
linaro.org> wrote:
> > On 05-07-21, 14:53, Jie Deng wrote:
> 
> > > +#include <linux/types.h>
> > > +#include <linux/const.h>
> >
> > Both of these need to be the uapi headers as Andy said earlier
> 
> They are already since this header _is_ UAPI,
Ahh, there is some tricky header inclusion there :)
> what you are suggesting is gonna not work,
Why ?
> although it's correct for in-kernel users of UAPI
> headers.
-- 
viresh

On Mon, Jul 5, 2021 at 11:56 AM Viresh Kumar <viresh.kumar at linaro.org>
wrote:
> On 05-07-21, 11:45, Andy Shevchenko wrote:
> > On Mon, Jul 5, 2021 at 11:03 AM Viresh Kumar <viresh.kumar at
linaro.org> wrote:
> > > On 05-07-21, 14:53, Jie Deng wrote:
> >
> > > > +#include <linux/types.h>
> > > > +#include <linux/const.h>
> > >
> > > Both of these need to be the uapi headers as Andy said earlier
> >
> > They are already since this header _is_ UAPI,
>
> Ahh, there is some tricky header inclusion there :)
>
> > what you are suggesting is gonna not work,
>
> Why ?
Because we do not have "uapi" in the path in /usr/include on the real
system where the linux-headers (or kernel-headers) package is
installed.

It's still possible that our installation hooks will remove that
"uapi" from the headers, but I think it makes things too complicated.
> > although it's correct for in-kernel users of UAPI
> > headers.

-- 
With Best Regards,
Andy Shevchenko