Andy Shevchenko
2021-Jul-05 08:45 UTC
[PATCH v13] i2c: virtio: add a virtio i2c frontend driver
On Mon, Jul 5, 2021 at 11:03 AM Viresh Kumar <viresh.kumar at linaro.org> wrote:> On 05-07-21, 14:53, Jie Deng wrote:> > +#include <linux/types.h> > > +#include <linux/const.h> > > Both of these need to be the uapi headers as Andy said earlierThey are already since this header _is_ UAPI, what you are suggesting is gonna not work, although it's correct for in-kernel users of UAPI headers.> and they better > be in alphabetical order.I prefer that as well.> #include <uapi/linux/const.h> > #include <uapi/linux/types.h>-- With Best Regards, Andy Shevchenko
Viresh Kumar
2021-Jul-05 08:56 UTC
[PATCH v13] i2c: virtio: add a virtio i2c frontend driver
On 05-07-21, 11:45, Andy Shevchenko wrote:> On Mon, Jul 5, 2021 at 11:03 AM Viresh Kumar <viresh.kumar at linaro.org> wrote: > > On 05-07-21, 14:53, Jie Deng wrote: > > > > +#include <linux/types.h> > > > +#include <linux/const.h> > > > > Both of these need to be the uapi headers as Andy said earlier > > They are already since this header _is_ UAPI,Ahh, there is some tricky header inclusion there :)> what you are suggesting is gonna not work,Why ?> although it's correct for in-kernel users of UAPI > headers.-- viresh