Now that we have completed 1.0 support, enable it in our driver.
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
drivers/net/virtio_net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index a0e64cf..c6a72d3 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2003,6 +2003,7 @@ static unsigned int features[] = {
VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ,
VIRTIO_NET_F_CTRL_MAC_ADDR,
VIRTIO_F_ANY_LAYOUT,
+ VIRTIO_F_VERSION_1,
};
static struct virtio_driver virtio_net_driver = {
--
MST
On Tue, 25 Nov 2014 18:43:06 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote:> Now that we have completed 1.0 support, enable it in our driver. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/net/virtio_net.c | 1 + > 1 file changed, 1 insertion(+) >Hm. The spec states that mac is driver-writable in the legacy case. Don't we need to fence writing it in virtnet_set_mac_address() in the virtio 1.0 case?
On Wed, Nov 26, 2014 at 02:08:57PM +0100, Cornelia Huck wrote:> On Tue, 25 Nov 2014 18:43:06 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > Now that we have completed 1.0 support, enable it in our driver. > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > > drivers/net/virtio_net.c | 1 + > > 1 file changed, 1 insertion(+) > > > > Hm. The spec states that mac is driver-writable in the legacy case. > Don't we need to fence writing it in virtnet_set_mac_address() in the > virtio 1.0 case?You are right. I'll add a patch to fix that one: we should return -EOPNOTSUPP unless VIRTIO_NET_F_CTRL_MAC_ADDR or VERSION_1 is clear and VIRTIO_NET_F_MAC is set.