search for: version_1

Why does the subset not work in the which() version below? Thank you v1 <- subset(t1, version_1==as.character("100-1") | version_1==as.character("100-2")) a<-c("100-1", "100-2") v1 <- subset(t1, which(a==as.character(version_1)) != 0) [[alternative HTML version deleted]]

On Mo, 2015-03-23 at 15:54 +0100, Michael S. Tsirkin wrote: > On Mon, Mar 23, 2015 at 03:27:35PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > > > > > virtio_cread will do byteswaps differently without VERSION_1. > > > > > > Just don't go there. > > > > > So to clarify, you dislike using __virtio32 in virtio input header? > > > > Well, as I understand thi...

On Mo, 2015-03-23 at 15:54 +0100, Michael S. Tsirkin wrote: > On Mon, Mar 23, 2015 at 03:27:35PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > > > > > virtio_cread will do byteswaps differently without VERSION_1. > > > > > > Just don't go there. > > > > > So to clarify, you dislike using __virtio32 in virtio input header? > > > > Well, as I understand thi...

Hi, > > > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > > > virtio_cread will do byteswaps differently without VERSION_1. > > > > Just don't go there. > So to clarify, you dislike using __virtio32 in virtio input header? Well, as I understand things __virtio32 implies byteorder depends on whenever we are...

Hi, > > > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > > > virtio_cread will do byteswaps differently without VERSION_1. > > > > Just don't go there. > So to clarify, you dislike using __virtio32 in virtio input header? Well, as I understand things __virtio32 implies byteorder depends on whenever we are...

ANY_LAYOUT is a compatibility feature. It's implied for VERSION_1 devices, and non-transitional devices might not offer it. Change code to behave accordingly. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio...

ANY_LAYOUT is a compatibility feature. It's implied for VERSION_1 devices, and non-transitional devices might not offer it. Change code to behave accordingly. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio...

...on does, > > and maybe wrap it in a helper like virtio_input_bitmap_copy or > > virtio_bitmap_or. > > Can do that, sure. Well, the function where this is in already cares about the bitmap copy only. Can add a comment though. > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > virtio_cread will do byteswaps differently without VERSION_1. > > Just don't go there. > > Changed that for v2, for the config space structs. They have normal u32 > in there now. virtio_cread() wants it this way. I liked the __le32 in the config space st...

...on does, > > and maybe wrap it in a helper like virtio_input_bitmap_copy or > > virtio_bitmap_or. > > Can do that, sure. Well, the function where this is in already cares about the bitmap copy only. Can add a comment though. > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > virtio_cread will do byteswaps differently without VERSION_1. > > Just don't go there. > > Changed that for v2, for the config space structs. They have normal u32 > in there now. virtio_cread() wants it this way. I liked the __le32 in the config space st...

On Thu, Dec 11, 2014 at 02:25:21PM +0100, Cornelia Huck wrote: > Wire up virtio-blk to provide different feature bit sets depending > on whether legacy or v1.0 has been requested. > > Note that VERSION_1 is still disabled due to missing ANY_LAYOUT support. > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> So we need some way for devices to tell transports not to negotiate rev 1. Does clearing VERSION_1 have this effect? > --- > hw/block/virtio-blk.c | 19 ++++++...

On Thu, Dec 11, 2014 at 02:25:21PM +0100, Cornelia Huck wrote: > Wire up virtio-blk to provide different feature bit sets depending > on whether legacy or v1.0 has been requested. > > Note that VERSION_1 is still disabled due to missing ANY_LAYOUT support. > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> So we need some way for devices to tell transports not to negotiate rev 1. Does clearing VERSION_1 have this effect? > --- > hw/block/virtio-blk.c | 19 ++++++...

With VERSION_1 virtio_net uses same header size whether mergeable buffers are enabled or not. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 0...

With VERSION_1 virtio_net uses same header size whether mergeable buffers are enabled or not. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi...

...ot; <mst at redhat.com> wrote: > > > On Thu, Dec 11, 2014 at 02:25:21PM +0100, Cornelia Huck wrote: > > > Wire up virtio-blk to provide different feature bit sets depending > > > on whether legacy or v1.0 has been requested. > > > > > > Note that VERSION_1 is still disabled due to missing ANY_LAYOUT support. > > > > > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > > > So we need some way for devices to tell transports > > not to negotiate rev 1. > > Does clearing VERSION_1 have this...

With VERSION_1 virtio_net uses same header size whether mergeable buffers are enabled or not. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 0...

With VERSION_1 virtio_net uses same header size whether mergeable buffers are enabled or not. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi...

...ot; <mst at redhat.com> wrote: > > > On Thu, Dec 11, 2014 at 02:25:21PM +0100, Cornelia Huck wrote: > > > Wire up virtio-blk to provide different feature bit sets depending > > > on whether legacy or v1.0 has been requested. > > > > > > Note that VERSION_1 is still disabled due to missing ANY_LAYOUT support. > > > > > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > > > So we need some way for devices to tell transports > > not to negotiate rev 1. > > Does clearing VERSION_1 have this...

From: "Michael S. Tsirkin" <mst at redhat.com> Date: Wed, 15 Jul 2015 15:26:19 +0300 > ANY_LAYOUT is a compatibility feature. It's implied > for VERSION_1 devices, and non-transitional devices > might not offer it. Change code to behave accordingly. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Applied.

With VERSION_1 virtio_net uses same header size whether mergeable buffers are enabled or not. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 9...

With VERSION_1 virtio_net uses same header size whether mergeable buffers are enabled or not. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 0...