tinc devel - May 2015 - tinc 1.1 "Got ADD_EDGE ... which does not match existing entry"

On Fri, 15 May 2015, Guus Sliepen wrote:
> On Fri, May 15, 2015 at 10:26:46PM +0200, Sven-Haegar Koch wrote:
> 
> > Another strange and difficult to understand thing - seems like all the
> > easy bugs in 1.1 are gone ;)
> [...]
> > Got ADD_EDGE from aaa_vpnhub1 (1.2.3.4 port 443) for haegar_tokamak 
> > -> igor which does not match existing entry (Local address 2.3.4.5 
> > != unknown)
> > 
> > What I think may happen is that the 1.1 nodes pass on the
local_address,
> > but the 1.0 nodes (as they don't know that field) do not -
resulting in
> > "unknown" in an ADD_EDGE message, which in turn the 1.1
nodes pass on.
> > 
> > Wouldn't it make sense that when the only difference between the
update
> > and the current edge record is the local_address, and the ADD_EDGE 
> > message says "unknown local_address", to not remove a
perhaps
> > pre-existing local_address entry, and more important to not send this 
> > "unknown" out again to all others, in turn making them
forget about it,
> > until the "unknown" ADD_EDGE reaches the node itself, which
will then
> > send out another ADD_EDGE with the again filled-in value?
> 
> It seems you have a perfect understanding of this bug, so perhaps it was
> not so difficult to understand after all? Fix committed :)
This change is not so good:

Connection with aaa_vpnhub1 (1.2.3.4 port 443) activated
Error while translating addresses: ai_family not supported

(And then the tinc process exists)

c'ya
sven-haegar

-- 
Three may keep a secret, if two of them are dead.
- Ben F.

On Sat, May 16, 2015 at 12:09:52AM +0200, Sven-Haegar Koch wrote:
> This change is not so good:
> 
> Connection with aaa_vpnhub1 (1.2.3.4 port 443) activated
> Error while translating addresses: ai_family not supported
> 
> (And then the tinc process exists)
Hm, I couldn't reproduce it, but I committed a fix anyway that makes
sockaddr2str() handle AF_UNSPEC addresses. It might just have moved the
problem though.

-- 
Met vriendelijke groet / with kind regards,
     Guus Sliepen <guus at tinc-vpn.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL:
<http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20150516/c30b9d7c/attachment.sig>

On Sat, 16 May 2015, Guus Sliepen wrote:
> On Sat, May 16, 2015 at 12:09:52AM +0200, Sven-Haegar Koch wrote:
> 
> > This change is not so good:
> > 
> > Connection with aaa_vpnhub1 (1.2.3.4 port 443) activated
> > Error while translating addresses: ai_family not supported
> > 
> > (And then the tinc process exists)
> 
> Hm, I couldn't reproduce it, but I committed a fix anyway that makes
> sockaddr2str() handle AF_UNSPEC addresses. It might just have moved the
> problem though.
Thanks Guus.
At least it does not explode anymore ;)

"tinc dump edges" contains a wild mix of "local unspec port
unspec",
"local unknown port unknown" and some adresses, but I assume that is 
expected and ok.

c'ya
sven-haegar

-- 
Three may keep a secret, if two of them are dead.
- Ben F.