Syslinux - Apr 2017 - fwd: [syslinux:syslinux-4.xx] mbr/isohdpfx.S: correct stack for heads/sectors

Hi,

FYI  syslinux upstream has a bugfix.
Both in the 6.xx branch and the 4.xx branch.


----- Forwarded message from syslinux-bot for Martin Str|mberg <ams at
ludd.ltu.se> -----

Date: Sat, 15 Apr 2017 10:27:08 -0700
From: syslinux-bot for Martin Str|mberg <ams at ludd.ltu.se>
To: Syslinux commits mailing list <syslinux-commits at zytor.com>
Cc: ams at ludd.ltu.se
Subject: [syslinux:syslinux-4.xx] mbr/isohdpfx.S: correct stack for
heads/sectors; revert
X-Mailer: Syslinux-git-log-daemon

Commit-ID:  45af3d24578783c53781050ef2a233dc84ff5ffd
Gitweb:    
http://www.syslinux.org/commit/45af3d24578783c53781050ef2a233dc84ff5ffd
Author:     Martin Str|mberg <ams at ludd.ltu.se>
AuthorDate: Sun, 26 Mar 2017 07:32:11 -0400
Committer:  Gene Cumm <gene.cumm at gmail.com>
CommitDate: Sat, 15 Apr 2017 13:24:38 -0400

mbr/isohdpfx.S: correct stack for heads/sectors; revert

Heads and sectors were pushed in reverse order per isolinux.asm

bb519a95 reversed the order of heads/sectors on the stack

Signed-off-by: Gene Cumm <gene.cumm at gmail.com>

---
 mbr/isohdpfx.S | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mbr/isohdpfx.S b/mbr/isohdpfx.S
index 17e1efe..f9e9691 100644
--- a/mbr/isohdpfx.S
+++ b/mbr/isohdpfx.S
@@ -175,12 +175,12 @@ next:
 	/* Get (C)HS geometry */
 	movb	$0x08, %ah
 	int	$0x13
-	andw	$0x3f, %cx	/* Sector count */
 	popw	%bx		/* EBIOS flag */
-	pushw	%cx		/* -16: Save sectors on the stack */
 	movzbw	%dh, %ax	/* dh = max head */
 	incw	%ax		/* From 0-based max to count */
-	pushw	%ax		/* -18: Save heads on the stack */
+	pushw	%ax		/* -16: Save heads on the stack */
+	andw	$0x3f, %cx	/* Sector count */
+	pushw	%cx		/* -18: Save sectors on the stack */
 	mulw	%cx		/* Heads*sectors -> sectors per cylinder */
 
 	pushw	%bx		/* -20: EBIOS flag */
_______________________________________________
Syslinux-commits mailing list
Syslinux-commits at zytor.com
http://www.zytor.com/mailman/listinfo/syslinux-commits

----- End forwarded message -----

-- 
Groeten
Geert Stappers
-- 
Leven en laten leven

On Sun, Apr 16, 2017 at 11:23:22PM +0200, Geert Stappers
wrote:
>
>Hi,
>
>FYI  syslinux upstream has a bugfix.
>Both in the 6.xx branch and the 4.xx branch.
ACK!

Geert, would you like to prepare uploads? This is a major fix that
clearly we should try to get into the archive for stretch, and also a
stable update for jessie.

-- 
Steve McIntyre, Cambridge, UK.                                steve at
einval.com
"When C++ is your hammer, everything looks like a thumb." -- Steven M.
Haflich