On Sun, Mar 26, 2017 at 08:14:39AM -0400, Gene Cumm via Syslinux wrote:> On Sun, Mar 26, 2017 at 6:43 AM, Ady Ady via Syslinux wrote: > > > > Then I would suggest: > > 1_ revert the wrong commit; > > 2_ apply the first part of the "right" patch in one commit, as it > > corrects one known bug; > > 3_ apply the second part of the "right" patch in a separated commit, > > which can potentially deal with a different situation than the first > > part of the patch, and, if for some reason additional space is needed > > in the future, it could be considered on its own for future edition. > > > > Essentially the approach I took on the isohdpfx branch on my personal repos.And meanwhile at the more central git repository. Thank you Gene. @Martin: I think `git rebase master` might need minor manual labour. Groeten Geert Stappers -- Leven en laten leven
> And meanwhile at the more central git repository. > > Thank you Gene. >The following two commits: _ mbr/isohdpfx.S: correct stack for heads/sectors; revert 32c09027423f61c305e2423e52f5f69ecad8e2c0 http://git.zytor.com/syslinux/syslinux.git/commit/?id=32c09027423f61c305 e2423e52f5f69ecad8e2c0 _ mbr/isohdpfx.S: Clear CX on INT 13h AH 41h failure 8739e2ff9ba3f92652c8df846924fd00e1ce2753 http://git.zytor.com/syslinux/syslinux.git/commit/?id=8739e2ff9ba3f92652 c8df846924fd00e1ce2753 were recently applied to the Syslinux git Master Head. Their respective two patches: http://git.zytor.com/syslinux/syslinux.git/patch/?id=32c09027423f61c305e 2423e52f5f69ecad8e2c0 http://git.zytor.com/syslinux/syslinux.git/patch/?id=8739e2ff9ba3f92652c 8df846924fd00e1ce2753 can also be applied cleanly to the 'syslinux-4.xx' branch. Considering the following facts: _ the above two patches have more (potential) impact on older computers (than on newer ones); _ the 'syslinux-4.xx' branch is being used by many active (Linux) distributions, such as Slackware, SUSE, RHEL and their derivatives (e.g. Salix, OpenSUSE, Centos, Oracle, Scientific...) among many others; I would like to request for the aforementioned two patches to be also applied to the 'syslinux-4.xx' branch in the official Syslinux git repositories. TIA, Ady.
> > > And meanwhile at the more central git repository. > > > > Thank you Gene. > > > > > The following two commits: > > _ > mbr/isohdpfx.S: correct stack for heads/sectors; revert > > 32c09027423f61c305e2423e52f5f69ecad8e2c0 > > http://git.zytor.com/syslinux/syslinux.git/commit/?id=32c09027423f61c305 > e2423e52f5f69ecad8e2c0 > > _ > mbr/isohdpfx.S: Clear CX on INT 13h AH 41h failure > > 8739e2ff9ba3f92652c8df846924fd00e1ce2753 > > http://git.zytor.com/syslinux/syslinux.git/commit/?id=8739e2ff9ba3f92652 > c8df846924fd00e1ce2753 > > > were recently applied to the Syslinux git Master Head. > > > Their respective two patches: > > > http://git.zytor.com/syslinux/syslinux.git/patch/?id=32c09027423f61c305e > 2423e52f5f69ecad8e2c0 > > > http://git.zytor.com/syslinux/syslinux.git/patch/?id=8739e2ff9ba3f92652c > 8df846924fd00e1ce2753 > > can also be applied cleanly to the 'syslinux-4.xx' branch. > > > Considering the following facts: > > _ the above two patches have more (potential) impact on older computers > (than on newer ones); > > _ the 'syslinux-4.xx' branch is being used by many active (Linux) > distributions, such as Slackware, SUSE, RHEL and their derivatives > (e.g. Salix, OpenSUSE, Centos, Oracle, Scientific...) among many > others; > > > I would like to request for the aforementioned two patches to be also > applied > to the 'syslinux-4.xx' branch in the official Syslinux git > repositories. > > TIA, > Ady.Is there any reason not to apply this to 'syslinux-4.xx'? I would really like to know. TIA, Ady.