The handover protocol uses ED as partition type but the comment above it still mentions EE Signed-off-by: Ruben Kerkhof <ruben at rubenkerkhof.com> --- mbr/gptmbr.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mbr/gptmbr.S b/mbr/gptmbr.S index 7f450d3..8ab6b50 100644 --- a/mbr/gptmbr.S +++ b/mbr/gptmbr.S @@ -194,7 +194,7 @@ found_part: pushw %di /* 80 00 00 00 ee 00 00 00 - - bootable partition, type EFI (EE), no CHS information */ + - bootable partition, type EFI (ED), no CHS information */ xorl %eax,%eax movb $0x80,%al stosl -- 1.8.4.2
Signed-off-by: Ruben Kerkhof <ruben at rubenkerkhof.com> --- mbr/gptmbr.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mbr/gptmbr.S b/mbr/gptmbr.S index 8ab6b50..7d98aee 100644 --- a/mbr/gptmbr.S +++ b/mbr/gptmbr.S @@ -213,7 +213,7 @@ found_part: movzwl %cx,%eax /* Length of GPT entry */ stosl - + rep; movsb /* GPT entry follows MBR entry */ popw %si -- 1.8.4.2
Ruben Kerkhof <ruben at rubenkerkhof.com> writes:> /* 80 00 00 00 ee 00 00 00 > - - bootable partition, type EFI (EE), no CHS information */ > + - bootable partition, type EFI (ED), no CHS information */Please fix the previous comment line as well. -- Regards, Feri.
Op 2013-12-15 om 17:39 schreef Ferenc Wagner:> Ruben Kerkhof <ruben at rubenkerkhof.com> writes: > > > /* 80 00 00 00 ee 00 00 00 > > - - bootable partition, type EFI (EE), no CHS information */ > > + - bootable partition, type EFI (ED), no CHS information */ > > Please fix the previous comment line as well.As I understand that, so in _my words_: Hello Ruben, Thank you for your patch to the Syslinux project. You spotted indeed a mismatch between code and comment. Reviewing your patch revealed other mismatch. Please rework your patch and submit it again to the mailinglist. Groeten Geert Stappers -- $ git diff -U5 mbr/gptmbr.S diff --git a/mbr/gptmbr.S b/mbr/gptmbr.S index 7f450d3..327cfa1 100644 --- a/mbr/gptmbr.S +++ b/mbr/gptmbr.S @@ -191,12 +191,12 @@ found_part: xchgw %ax,%cx /* Set up %cx for rep movsb further down */ movw $dssi_out,%di pushw %di - /* 80 00 00 00 ee 00 00 00 - - bootable partition, type EFI (EE), no CHS information */ + /* 80 00 00 00 ed 00 00 00 + - bootable partition, type EFI (ED), no CHS information */ xorl %eax,%eax movb $0x80,%al stosl movb $0xed,%al stosl
Op 2013-12-14 om 21:34 schreef Ruben Kerkhof:> Signed-off-by: Ruben Kerkhof <ruben at rubenkerkhof.com> > --- > mbr/gptmbr.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mbr/gptmbr.S b/mbr/gptmbr.S > index 8ab6b50..7d98aee 100644 > --- a/mbr/gptmbr.S > +++ b/mbr/gptmbr.S > @@ -213,7 +213,7 @@ found_part: > > movzwl %cx,%eax /* Length of GPT entry */ > stosl > - > + > rep; movsb /* GPT entry follows MBR entry */ > popw %si >The removal of that trailing tab character is valid change. What is needed to get the patch applied in the leading git repository? Groeten Geert Stappers -- Leven en laten leven