Displaying 3 results from an estimated 3 matches for "7f450d3".
2013 Dec 14
4
[PATCH 1/2] Match comment with code
The handover protocol uses ED as partition type
but the comment above it still mentions EE
Signed-off-by: Ruben Kerkhof <ruben at rubenkerkhof.com>
---
mbr/gptmbr.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mbr/gptmbr.S b/mbr/gptmbr.S
index 7f450d3..8ab6b50 100644
--- a/mbr/gptmbr.S
+++ b/mbr/gptmbr.S
@@ -194,7 +194,7 @@ found_part:
pushw %di
/* 80 00 00 00 ee 00 00 00
- - bootable partition, type EFI (EE), no CHS information */
+ - bootable partition, type EFI (ED), no CHS information */
xorl %eax,%eax
movb $0x80,%al
stosl...
2013 Dec 15
3
[PATCH 1/2] Match comment with code
...o the Syslinux project.
You spotted indeed a mismatch between code and comment.
Reviewing your patch revealed other mismatch.
Please rework your patch and submit it again to the mailinglist.
Groeten
Geert Stappers
--
$ git diff -U5 mbr/gptmbr.S
diff --git a/mbr/gptmbr.S b/mbr/gptmbr.S
index 7f450d3..327cfa1 100644
--- a/mbr/gptmbr.S
+++ b/mbr/gptmbr.S
@@ -191,12 +191,12 @@ found_part:
xchgw %ax,%cx /* Set up %cx for rep movsb further down */
movw $dssi_out,%di
pushw %di
- /* 80 00 00 00 ee 00 00 00
- - bootable partition, type EFI (EE)...
2013 Dec 15
0
[PATCH 1/2] Match comment with code
...d comment.
>
> Reviewing your patch revealed other mismatch.
>
> Please rework your patch and submit it again to the mailinglist.
>
>
>
> Groeten
> Geert Stappers
>
> --
> $ git diff -U5 mbr/gptmbr.S
> diff --git a/mbr/gptmbr.S b/mbr/gptmbr.S
> index 7f450d3..327cfa1 100644
> --- a/mbr/gptmbr.S
> +++ b/mbr/gptmbr.S
> @@ -191,12 +191,12 @@ found_part:
> xchgw %ax,%cx /* Set up %cx for rep movsb further down */
>
> movw $dssi_out,%di
> pushw %di
>
> - /* 80 00 00 00 ee 00 00 00
&...