Gene Cumm
2008-Nov-02 16:44 UTC
[syslinux] [PATCH 1/1] com32/libutil/Makefile: Duplicate spotless target
From: Gene Cumm <gene.cumm at gmail.com>
Fix duplicate spotless target in com32/libutil/Makefile.
Signed-off-by: Gene Cumm <gene.cumm at gmail.com>
---
diff --git a/com32/libutil/Makefile b/com32/libutil/Makefile
index 31754a9..02789ca 100644
--- a/com32/libutil/Makefile
+++ b/com32/libutil/Makefile
@@ -56,8 +56,6 @@ clean: tidy
spotless: clean
rm -f *.lss *.a *.c32 *.com
-
-spotless: clean
rm -f *~ \#*
install: all
Gene Cumm
2008-Nov-02 17:00 UTC
[syslinux] [PATCH 1/1] com32/libutil/Makefile: Duplicate spotless target
On Sun, Nov 2, 2008 at 11:44 AM, Gene Cumm <gene.cumm at gmail.com> wrote:> From: Gene Cumm <gene.cumm at gmail.com> > > Fix duplicate spotless target in com32/libutil/Makefile. > > Signed-off-by: Gene Cumm <gene.cumm at gmail.com> > > --- > > diff --git a/com32/libutil/Makefile b/com32/libutil/Makefile > index 31754a9..02789ca 100644 > --- a/com32/libutil/Makefile > +++ b/com32/libutil/Makefile > @@ -56,8 +56,6 @@ clean: tidy > > spotless: clean > rm -f *.lss *.a *.c32 *.com > - > -spotless: clean > rm -f *~ \#* > > install: all >Peter, I'm looking at commit ed67201fcc004ccb0eb20e5489d71ed69cfb7428 (tag syslinux-3.72) and trying to understand if another change needs to be made as follows: diff --git a/com32/libutil/Makefile b/com32/libutil/Makefile index 02789ca..c1a17e1 100644 --- a/com32/libutil/Makefile +++ b/com32/libutil/Makefile @@ -52,7 +52,7 @@ tidy dist: rm -f *.o *.lo *.lst *.elf .*.d *.tmp clean: tidy - rm -f *.lnx libutil_lnx.a + rm -f *.lnx libutil_com.a libutil_lnx.a spotless: clean rm -f *.lss *.a *.c32 *.com Your comment in the commit is that ' "make clean" must NOT remove stuff that "make installer" should not rebuild.' Does that mean that make clean should remove both libutil_com.a and libutil_lnx.a?