thr3ads.net - Swfdec - [Swfdec] [PATCH] fix issues from latest commits [Jun 2008]

If this information is useful, please help other people find it:
Share via:

Riccardo Magliocchetti

2008-Jun-07 09:53 UTC

[Swfdec] [PATCH] fix issues from latest commits

hi,

attacched a couple of patches that fix:

- a variable may be used unitialized in swfdec_audio_decoder.c

- swfdec_init.c got referenced in swfdec/Makefile.am but it's not in 
git, i've removed it but maybe the right fix is to add it instead

Still not able to compile swfdec (shadow warnings), will follow other 
patches if you don't beat me to it.

cheers,
rm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-reference-to-swfdec-init.diff
Type: text/x-diff
Size: 336 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/swfdec/attachments/20080607/0977d588/attachment.diff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: initialize-pointer-to-null.diff
Type: text/x-diff
Size: 516 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/swfdec/attachments/20080607/0977d588/attachment-0001.diff

Riccardo Magliocchetti

2008-Jun-07 10:00 UTC

head link

[Swfdec] [PATCH] fix issues from latest commits

Riccardo Magliocchetti wrote:> Still not able to compile swfdec (shadow warnings), will follow other 
> patches if you don't beat me to it.
ouch, the problem is in gstreamer (0.10.19) vs time.h (clock, time) and 
stdlib.h (free) :|

In file included from /usr/include/gstreamer-0.10/gst/gstbuffer.h:28,
                  from /usr/include/gstreamer-0.10/gst/gstpad.h:30,
                  from /usr/include/gstreamer-0.10/gst/gstelement.h:53,
                  from /usr/include/gstreamer-0.10/gst/gstbin.h:27,
                  from /usr/include/gstreamer-0.10/gst/gst.h:34,
                  from /usr/include/gstreamer-0.10/gst/pbutils/pbutils.h:23,
                  from swfdec_audio_decoder_gst.c:24:
/usr/include/gstreamer-0.10/gst/gstclock.h:248: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:248: warning: declaration of 
'time' shadows a global declaration
/usr/include/time.h:187: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:472: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:475: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:477: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:480: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:481: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:482: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:485: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:493: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:495: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:497: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:498: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:502: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:508: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:509: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:510: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:515: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:516: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:517: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:521: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:522: warning: declaration of 
'time' shadows a global declaration
/usr/include/time.h:187: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstclock.h:523: warning: declaration of 
'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
In file included from /usr/include/gstreamer-0.10/gst/gstformat.h:30,
                  from /usr/include/gstreamer-0.10/gst/gstevent.h:29,
                  from /usr/include/gstreamer-0.10/gst/gstpad.h:32,
                  from /usr/include/gstreamer-0.10/gst/gstelement.h:53,
                  from /usr/include/gstreamer-0.10/gst/gstbin.h:27,
                  from /usr/include/gstreamer-0.10/gst/gst.h:34,
                  from /usr/include/gstreamer-0.10/gst/pbutils/pbutils.h:23,
                  from swfdec_audio_decoder_gst.c:24:
/usr/include/gstreamer-0.10/gst/gstiterator.h:219: warning: declaration 
of 'free' shadows a global declaration
/usr/include/stdlib.h:488: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstiterator.h:227: warning: declaration 
of 'free' shadows a global declaration
/usr/include/stdlib.h:488: warning: shadowed declaration is here
In file included from /usr/include/gstreamer-0.10/gst/gstbus.h:29,
                  from /usr/include/gstreamer-0.10/gst/gstelement.h:54,
                  from /usr/include/gstreamer-0.10/gst/gstbin.h:27,
                  from /usr/include/gstreamer-0.10/gst/gst.h:34,
                  from /usr/include/gstreamer-0.10/gst/pbutils/pbutils.h:23,
                  from swfdec_audio_decoder_gst.c:24:
/usr/include/gstreamer-0.10/gst/gstmessage.h:282: warning: declaration 
of 'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstmessage.h:283: warning: declaration 
of 'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstmessage.h:284: warning: declaration 
of 'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstmessage.h:304: warning: declaration 
of 'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstmessage.h:305: warning: declaration 
of 'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstmessage.h:306: warning: declaration 
of 'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
In file included from /usr/include/gstreamer-0.10/gst/gstbin.h:27,
                  from /usr/include/gstreamer-0.10/gst/gst.h:34,
                  from /usr/include/gstreamer-0.10/gst/pbutils/pbutils.h:23,
                  from swfdec_audio_decoder_gst.c:24:
/usr/include/gstreamer-0.10/gst/gstelement.h:515: warning: declaration 
of 'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstelement.h:586: warning: declaration 
of 'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstelement.h:587: warning: declaration 
of 'time' shadows a global declaration
/usr/include/time.h:187: warning: shadowed declaration is here
In file included from /usr/include/gstreamer-0.10/gst/gst.h:55,
                  from /usr/include/gstreamer-0.10/gst/pbutils/pbutils.h:23,
                  from swfdec_audio_decoder_gst.c:24:
/usr/include/gstreamer-0.10/gst/gstpipeline.h:95: warning: declaration 
of 'time' shadows a global declaration
/usr/include/time.h:187: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstpipeline.h:98: warning: declaration 
of 'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstpipeline.h:99: warning: declaration 
of 'clock' shadows a global declaration
/usr/include/time.h:184: warning: shadowed declaration is here
In file included from /usr/include/gstreamer-0.10/gst/gst.h:60,
                  from /usr/include/gstreamer-0.10/gst/pbutils/pbutils.h:23,
                  from swfdec_audio_decoder_gst.c:24:
/usr/include/gstreamer-0.10/gst/gstsegment.h:91: warning: declaration of 
'time' shadows a global declaration
/usr/include/time.h:187: warning: shadowed declaration is here
/usr/include/gstreamer-0.10/gst/gstsegment.h:94: warning: declaration of 
'time' shadows a global declaration
/usr/include/time.h:187: warning: shadowed declaration is here

thanks,
rm

Benjamin Otte

2008-Jun-08 12:08 UTC

head link

[Swfdec] [PATCH] fix issues from latest commits

On Sat, Jun 7, 2008 at 11:53 AM, Riccardo Magliocchetti
<riccardo.magliocchetti at gmail.com> wrote:> attacched a couple of patches that fix:
>Applied the fixes. I also removed -Wshadow from the warning flags,
until gcc gets around fixing the warning.
> - swfdec_init.c got referenced in swfdec/Makefile.am but it's not in
git,
> i've removed it but maybe the right fix is to add it instead
>I added swfdec_init.c as I had forgotten it previously, it contains
swfdec_init() now so you cannot live without it. However, as I didn't
want lots of broken commits, I fixed the commit where I had moved that
function to its new file. And that in turn means I rebased master. So
if a pull fails for you now, it's my fault. Besides, you don't wanna
use git-pull anyway, but git fetch && git rebase origin :)

Cheers,
Benjamin

Reasonably Related Threads

Search for more apparently analagous threads

Swfdec - Jun 2008 - [PATCH] fix issues from latest commits

[Swfdec] [PATCH] fix issues from latest commits

[Swfdec] [PATCH] fix issues from latest commits

[Swfdec] [PATCH] fix issues from latest commits

Reasonably Related Threads